Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: compilation on Docker #11

Merged
merged 2 commits into from
Mar 24, 2021
Merged

🐛 FIX: compilation on Docker #11

merged 2 commits into from
Mar 24, 2021

Conversation

chrisjsewell
Copy link
Member

On Docker the image should not be compiled to use the host's spec,
since it could be used on another platform

On Docker the image should not be compiled to use the host's spec,
since it could be used on another platform
@chrisjsewell
Copy link
Member Author

For reference the change does appear to affect the speed of abinit (when running tests):

Before PR:

    marvel-nccr.abinit : Make abinit executable (2 cpu) ------------------- 646.38s
    marvel-nccr.abinit : run the tests (2 cpu) ---------------------------- 229.43s

After PR:

    marvel-nccr.abinit : Make abinit executable (2 cpu) ------------------- 645.44s
    marvel-nccr.abinit : run the tests (2 cpu) ---------------------------- 262.08s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant