-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compilation fails on Quantum Mobile (1st attempt only) #11
Comments
Actually this error on yaml should be harmless I think, it keeps going with the python version it found (but yes, it might still be better with setuptools). Checking quickly in the logs of the linked build, I see that messages This seems to be the failing point ... I found some sources saying that virtualbox is subject to drifts, for example when the host is suspended for a while, the guest time is out of sync. I'll see if I can reproduce this behaviour elsewhere |
Thanks for the analysis, I guess as at least a temporary fix we can add a retry to the make task |
I published v1.3.5 with a retry attempt if the build fails. |
Thanks but... I'm going to be a bit of a stickler here and ask can you please adhere to the formal PR and review process for making these changes 😬 |
In #11 it was found that the compilation can fail on VirtualBox, potentially due to a discrepancy in clocks (when checking modified times of files). As a preliminary fix, we add a retry to the compilation.
Indeed, I'll try to do it properly from now on. Thanks for the other changes. |
I didn't notice this before but the compilation is failing, both locally and in the CI (https://github.com/marvel-nccr/quantum-mobile/runs/1287141082?check_suite_focus=true). But weirdly it passes on the second pass.
It looks possibly to do with:
/usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'python_requires'
which I believe is due to the version of setuptools being too old (but somehow being ok on the second pass!?).So I will try making a PR to ensure that the setuptools version is up-to-date.
On a related note, the whole bespoke build/installation of pyyaml all feels a bit unnecessary TBH, it would be nice if you could just replace it with
pip install pyyaml~=5.1.2
The text was updated successfully, but these errors were encountered: