fix(deps): upgrade tools and mod packages #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses an error with newer versions of Go. fix marwan-at-work#9
| @@ -8,7 +8,7 @@ require ( | |||
| github.com/google/go-querystring v0.0.0-20170111101155-53e6ce116135 // indirect | |||
| github.com/pkg/errors v0.9.1 | |||
| github.com/urfave/cli/v2 v2.3.0 | |||
| golang.org/x/mod v0.2.0 | |||
| golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 | |||
There was a problem hiding this comment.
any reason not to use the latest stable which is v0.5.1 https://pkg.go.dev/golang.org/x/mod ?
There was a problem hiding this comment.
It was bumped automatically as a dependency of tools. https://github.com/golang/tools/blob/v0.1.10/go.mod#L7
tools 0.1.9 uses mod 0.5.1. I tested that with my project and it still works. I can downgrade it if you want to use the stable version.
There was a problem hiding this comment.
I see. Will merge then, thanks!
uvegla
added a commit
to giantswarm/app-operator
that referenced
this pull request
Jun 8, 2022
See: marwan-at-work/mod#14 Should be upgraded in devctl
This was referenced Jun 8, 2022
uvegla
added a commit
to giantswarm/devctl
that referenced
this pull request
Jun 8, 2022
1 task
uvegla
added a commit
to giantswarm/app-operator
that referenced
this pull request
Jun 8, 2022
See: marwan-at-work/mod#14 Should be upgraded in devctl
uvegla
added a commit
to giantswarm/devctl
that referenced
this pull request
Jun 8, 2022
* Bump github.com/marwan-at-work/mod/cmd/mod to v0.4.2 See: https://github.com/giantswarm/app-operator/runs/6792943187?check_suite_focus=true See: marwan-at-work/mod#14 * Update CHANGELOG.md * Bump dependencies to solve security issues * Bump some dependencies to solve issues and ignore some reports for now * Format go.mod
ubergesundheit
pushed a commit
to ubergesundheit/devctl-templates
that referenced
this pull request
Apr 2, 2024
* Bump github.com/marwan-at-work/mod/cmd/mod to v0.4.2 See: https://github.com/giantswarm/app-operator/runs/6792943187?check_suite_focus=true See: marwan-at-work/mod#14 * Update CHANGELOG.md * Bump dependencies to solve security issues * Bump some dependencies to solve issues and ignore some reports for now * Format go.mod
ubergesundheit
pushed a commit
to ubergesundheit/devctl-templates
that referenced
this pull request
Apr 2, 2024
* Bump github.com/marwan-at-work/mod/cmd/mod to v0.4.2 See: https://github.com/giantswarm/app-operator/runs/6792943187?check_suite_focus=true See: marwan-at-work/mod#14 * Update CHANGELOG.md * Bump dependencies to solve security issues * Bump some dependencies to solve issues and ignore some reports for now * Format go.mod
ubergesundheit
pushed a commit
to ubergesundheit/devctl-templates
that referenced
this pull request
Apr 2, 2024
* Bump github.com/marwan-at-work/mod/cmd/mod to v0.4.2 See: https://github.com/giantswarm/app-operator/runs/6792943187?check_suite_focus=true See: marwan-at-work/mod#14 * Update CHANGELOG.md * Bump dependencies to solve security issues * Bump some dependencies to solve issues and ignore some reports for now * Format go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered issue #9 in a project that uses Go 1.18. The project uses Renovate's gomodUpdateImportPaths option, which output this error:
I tested upgrading the tools package to the latest version locally, based on the solution the last time this issue was brought up, and the above command worked for my project.