Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show/hide toggle on non-problem pages #65

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

marwanhawari
Copy link
Owner

@marwanhawari marwanhawari commented Apr 15, 2024

Forgot that non-problem pages don't use the content script, so the show/hide toggle in the popup (added in #63) wasn't working for it. This PR fixes this.

Also fixes show/hide on problem page to read the toggle state from local storage before showing the panel. This makes it so that if the panel was minimized (but not hidden), then when you hide and un-hide, it will still be minimized instead of expanded.

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
leetrooms-extension ⬜️ Ignored (Inspect) Apr 15, 2024 4:10am
leetrooms-website ⬜️ Ignored (Inspect) Apr 15, 2024 4:10am

@github-actions github-actions bot added the extension A label for the LeetRooms web extension code label Apr 15, 2024
@marwanhawari marwanhawari merged commit 6ef4d33 into main Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension A label for the LeetRooms web extension code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant