This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Feature/#30 Use JS functionality in previews #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30 - Use JS funcionality in previews
main.min.js(jQuery/JS) intoTopHeader.jsx(react-friendly JS), such as the logo being visible after scrolling, and the header background change (not visible in Besugo's styleguide out-of-the-box).Notes
The
main.min.jsfile still exists and will still be needed on every project most likely.This means that porting the specific functions in this PR in other projects should "just work", but every project will have to be done on a case-by-case basis, meaning that each specific functionality (that should exist in the previews of course) will have to be ported individually.
For instance, in PWiT, we might leave the filters functionality in
main.min.js, since it won't be needed in any preview page. But we will definitely need to port a lot of functions in UHUB, such as the extras and related stuff.