build(meson): general improvements and fixes #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the / operator instead of join_paths Use the / operator instead of using "/" in string paths Use the includedir opt instead of hardcoding "include" in install_subdir Remove discouraged layout=flat option (mesonbuild/meson#9243) Remove unneeded Wextra, Wpedantic flags, already added by warning_level Remove manual -Oz flag when using Clang (mesonbuild/meson#9286) Make use of : in kwargs consistent
|
Didn't have time to run the tests, so I'm marking this as draft |
|
I won't be able to run the tests until this afternoon, but since all tests passed in CI I think that it is safe to mark this as ready for review |
|
Oh nice, I've learned a few things about meson from this PR. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change do?
Use the
/operator instead of join_pathsUse the
/operator instead of using "/" in string pathsUse the
includediropt instead of hardcoding "include" ininstall_subdirRemove discouraged
layout=flatoption (mesonbuild/meson#9243)Remove unneeded -Wextra, -Wpedantic flags, already added by
warning_level=3Remove manual -Oz flag when using Clang (mesonbuild/meson#9286)
Make use of : in kwargs consistent
Pre-merge checklist
origin/master(if necessary)