Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update at_path(toml::path) to handle missing component #168

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

kcsaul
Copy link
Contributor

@kcsaul kcsaul commented Aug 24, 2022

What does this change do?
Fix seg fault within at_path(toml::path) when there's a missing component

Is it related to an existing bug report or feature request?
No, new bug identified

Pre-merge checklist

  • I've read CONTRIBUTING.md
  • I've rebased my changes against the current HEAD of origin/master (if necessary)
  • I've added new test cases to verify my change
  • I've regenerated toml.hpp (how-to)
  • I've updated any affected documentation
  • I've rebuilt and run the tests with at least one of:
    • Clang 6 or higher
    • GCC 7 or higher
    • MSVC 19.20 (Visual Studio 2019) or higher
  • I've added my name to the list of contributors in README.md

@kcsaul kcsaul marked this pull request as ready for review August 25, 2022 01:25
@marzer marzer merged commit be0fbd5 into marzer:master Aug 25, 2022
@marzer
Copy link
Owner

marzer commented Aug 25, 2022

Nice catch, thanks!

@kcsaul
Copy link
Contributor Author

kcsaul commented Aug 25, 2022

Happy to help, thanks for reviewing & merging so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants