Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mas upgrade output #393

Closed
rgoldberg opened this issue Jun 4, 2021 · 3 comments · Fixed by #475
Closed

Improve mas upgrade output #393

rgoldberg opened this issue Jun 4, 2021 · 3 comments · Fixed by #475

Comments

@rgoldberg
Copy link
Contributor

rgoldberg commented Jun 4, 2021

Improve mas upgrade output from:

Upgrading 2 outdated applications:
Transporter (1.2.1), Developer (9.2)
==> Downloading Transporter
==> Installed Transporter
==> Downloading Apple Developer
==> Installed Apple Developer

Also, Downloading should be changed to Downloaded after the download has completed.

Maybe the displayed app names should be consistent, instead of using Developer at the top, and Apple Developer at the bottom. I assume we should use the longer name everywhere.

Describe the solution you'd like

Improve mas upgrade output to something like:

Upgrading 2 outdated applications:

Transporter 1.2.1 -> 1.2.2
Apple Developer 9.2 -> 9.2.1

==> Downloaded Transporter 1.2.2
==> Installed Transporter 1.2.2
==> Downloaded Apple Developer 9.2.1
==> Installed Apple Developer 9.2.1

Describe alternatives you've considered
Possibly use the shorter name everywhere.

Would be nice to space the the versions out in a table-spaced format (without borders) to make everything more readable, but I'd have to find some text spacing library. Not gonna spend time writing one myself. e.g.:

Upgrading 2 outdated applications:

Transporter     1.2.1 -> 1.2.2
Apple Developer 9.2   -> 9.2.1

==> Downloaded Transporter     1.2.2
==> Installed  Transporter     1.2.2
==> Downloaded Apple Developer 9.2.1
==> Installed  Apple Developer 9.2.1
@chris-araman
Copy link
Contributor

chris-araman commented Jun 4, 2021

I agree the existing output can be a little confusing. It's not always clear whether mas is showing the existing app version or the version to be upgraded. There's also confusion between bundle version, bundle short version, and App Store version, which don't always match, but that's probably outside the scope of this issue.

@rgoldberg, did you want to try putting together a pull request for this one? If you're interested, it seems like something that somebody new to Swift could pick up.

@rgoldberg
Copy link
Contributor Author

rgoldberg commented Jun 4, 2021

Yeah, I'm happy to create a PR.

@chris-araman: Do you know a Swift text formatting utility that can output plaintext in columns?

@chris-araman
Copy link
Contributor

I don't think a library will be necessary for tabulation. Take a look at the existing Formatters.

rgoldberg added a commit to rgoldberg/mas that referenced this issue Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants