Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App ID should be UInt64 instead of Int #478

Closed
1 task done
algorythmic opened this issue Nov 1, 2022 · 0 comments · Fixed by #570
Closed
1 task done

App ID should be UInt64 instead of Int #478

algorythmic opened this issue Nov 1, 2022 · 0 comments · Fixed by #570
Assignees
@rgoldberg
Labels
🐛 bug
Milestone
1.8.7

Comments

@algorythmic
Copy link

Your Environment

  • mas version: 1.8.6
  • macOS version (system_profiler SPSoftwareDataType -detailLevel mini): 13.0 (22A380)

mas Install Method

  • brew install mas (homebrew-core)

Describe the Bug

The App ID reported in mas search output is incorrect if the ID is a number larger than Int32.max.

To Reproduce

Search for a term that includes results with a high App ID.

Expected Behavior

mas search KeepPass
...
  6443922649  KeepPass Password Manager      (1.1)
...

Actual Behavior

mas search KeepPass
...
 -2146011943  KeepPass Password Manager      (1.1)
...
@algorythmic algorythmic mentioned this issue Nov 1, 2022
Closed
@rgoldberg rgoldberg mentioned this issue Sep 5, 2024
Closed
1 task
xyzzy-plugh-plover added a commit to xyzzy-plugh-plover/mas that referenced this issue Sep 11, 2024
@xyzzy-plugh-plover
🐛 Retype & display App IDs as UInt64
7fb9578 
Supersede mas-cli#479
Fix mas-cli#478

Signed-off-by: xyzzy-plugh-plover <114089973+xyzzy-plugh-plover@users.noreply.github.com>
@xyzzy-plugh-plover xyzzy-plugh-plover mentioned this issue Sep 11, 2024
Closed
This was referenced Sep 11, 2024
Closed
Closed
@rgoldberg rgoldberg changed the title 🐛 [BUG] App ID integer type confusion in search results App ID should be UInt64 instead of Int Sep 14, 2024
@rgoldberg rgoldberg added this to the 1.8.7 milestone Sep 15, 2024
@rgoldberg rgoldberg self-assigned this Sep 16, 2024
rgoldberg pushed a commit to xyzzy-plugh-plover/mas that referenced this issue Oct 6, 2024
@xyzzy-plugh-plover
🐛 Retype & display App IDs as UInt64
50946bb 
Supersede mas-cli#479
Fix mas-cli#478

Signed-off-by: xyzzy-plugh-plover <114089973+xyzzy-plugh-plover@users.noreply.github.com>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Oct 14, 2024
@rgoldberg
Create typealias AppID = UInt64.
512b96f 
Use `AppID` everywhere appropriate.

Associated appID cleanup.

Partial mas-cli#478

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Oct 14, 2024
@rgoldberg
Standardize names of variables & parameters relating to AppIDs.
651d36c 
Resolve mas-cli#478

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Oct 14, 2024
@rgoldberg
Create typealias AppID = UInt64.
39f77c0 
Use `AppID` everywhere appropriate.

Associated appID cleanup.

Partial mas-cli#478

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg mentioned this issue Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgoldberg rgoldberg

Labels
🐛 bug
Projects
None yet
Milestone
1.8.7
2 participants
@rgoldberg @algorythmic