Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve & standardize help output #543

Closed
rgoldberg opened this issue Oct 2, 2024 · 0 comments · Fixed by #610
Closed

Improve & standardize help output #543

rgoldberg opened this issue Oct 2, 2024 · 0 comments · Fixed by #610
Assignees
Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature 🖨 output

Comments

@rgoldberg
Copy link
Contributor

rgoldberg commented Oct 2, 2024

Improve & standardize help output.

Additionally specify what Apple IDs are used for each subcommand:

  • macOS Apple ID, which is associated with the current macOS user in System Settings/System Preferences. It can be observed:
    • In Swift:
    (UserDefaults.standard.persistentDomain(forName: "MobileMeAccounts")?["Accounts"] as? [[String: Any]])?.first?["AccountID"]
    
    • From command line:
    defaults read MobileMeAccounts | plutil -extract "Accounts".0."AccountID" raw -o - -
    
  • App Store Apple ID, which is when you login in the App Store app. It can be observed:
    • In Swift (in macOs <= 10.12.x):
    ISStoreAccount.primaryAccount.identifier
    
    • From command line: not sure

Currently, I think that the subcommands, when working, have the following interactions with the macOS & MAS Apple IDs:

  • MAS
    • account
    • signin
    • signout
  • MAS (requires app in macOS installed app list)
    • upgrade
  • MAS (requires app not in macOS installed app list)
    • install
    • lucky
    • purchase
  • macOS (requires app in macOS installed app list)
    • list
    • outdated
    • uninstall (currently used, but probably not strictly necessary)
  • Neither
    • help
    • home
    • info
    • open
    • reset
    • search
    • vendor
    • version

Also, standardize various variable names to conform to standardized naming in help, documentation, etc.

@rgoldberg rgoldberg added this to the 1.8.7 milestone Oct 2, 2024
@rgoldberg rgoldberg self-assigned this Oct 2, 2024
@rgoldberg rgoldberg added 🖨 output 🧹 cleanup Optimization of (not bug fix for) an existing feature and removed 🆕 feature request labels Oct 3, 2024
@rgoldberg rgoldberg removed this from the 1.8.7 milestone Oct 6, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Oct 27, 2024
Make fish shell completions more consistent with the help output.

Resolve mas-cli#543

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature 🖨 output
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant