Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧰 MasKit Framework #175

Merged
merged 14 commits into from
Oct 15, 2018
Merged

🧰 MasKit Framework #175

merged 14 commits into from
Oct 15, 2018

Conversation

phatblat
Copy link
Member

Split out logic into new MasKit framework target to make testing easier and to solve some packaging issues in the same way as Carthage as suggested in #169

@masclibot
Copy link

masclibot commented Oct 14, 2018

1 Warning
⚠️ 😵 Big PR

Generated by 🚫 Danger

@phatblat phatblat changed the title MasKit 📦 MasKit Oct 14, 2018
@phatblat phatblat changed the title 📦 MasKit 🧰 MasKit Framework Oct 14, 2018
@todo
Copy link

todo bot commented Oct 15, 2018

Move MasKit.frameworks to prefix/Frameworks

mas/Homebrew/mas.rb

Lines 23 to 28 in 1a0d4a6

bin.install buildpath/"build/mas"
# TODO: Move MasKit.frameworks to prefix/Frameworks
bash_completion.install "contrib/completion/mas-completion.bash" => "mas"
end


This comment was generated by todo based on a TODO comment in 1a0d4a6 in #175. cc @mas-cli.

@phatblat phatblat merged commit 6cfd520 into master Oct 15, 2018
@phatblat phatblat deleted the maskit branch October 15, 2018 04:34
@phatblat phatblat mentioned this pull request Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants