Fix outdated & upgrade commands #312

rgoldberg · 2021-01-17T10:55:21Z

Fix outdated & upgrade commands.

MasKit/Commands/Outdated.swift

MasKit/Commands/Upgrade.swift

rgoldberg · 2021-01-18T16:01:59Z

I force pushed some minor changes 14 hours ago, but the Jenkins/pr-merge check hasn't completed. How long does it normally take? Might something have gone wrong? 14 hours seems a long time, but maybe it's normal…

rgoldberg · 2021-01-19T04:10:39Z

The most recent Jenkins/pr-merge build failed, but previous builds succeeded.

The logs say that the Commandant build failed.

The only differences in the most recent force push were in CHANGELOG.md, which should not affect the Commandant build, right?

Supposedly, there's more info in the following file, but I don't know how to see the file:

/var/folders/8l/wsf0fx0x015dtgb_pwjyj3zr0000gr/T/carthage-xcodebuild.RDNixk.log

rgoldberg · 2021-01-19T04:57:57Z

Whenever I build, changes are made to spacing in various files that I haven't edited (presumably because the spacing violates various formatting rules).

Can I commit those spacing changes in this PR, so people don't keep getting files changed on them? Or should I create a new issue & PR?

There's also a bug in the InfoCommandSpec displays app details check: the expected value for Released is Jan 7, 2019, but on my machine, the value is 2019-01-07. Either:

the default medium date style must be changed locally in the test function
the system's default medium date style must be used to calculate the expected output, instead of hardcoding it to Jan 7, 2019
the InfoCommand must use a deterministic date format instead of one that is system configuration dependent
something else is causing my problem other than a system-wide medium date format that is different than what the test expects (but I don't know what that cause would be)

Which do you prefer?

rgoldberg · 2021-02-13T22:32:18Z

The file spacing is no longer changed by the build, presumably because of the change from swiftlint autocorrect --format to swiftlint autocorrect, but the Info_command__displays_app_details test date format error still occurs.

rgoldberg · 2021-02-15T20:45:45Z

Hi @phatblat, glad you’re recovering.

Sorry to bother you, but is there anything that I (or anyone else) must do to get the Jenkins/pr-merge check to run?

I pushed commits 2 days ago, and it still hasn’t run…

phatblat · 2021-02-18T01:31:07Z

@rgoldberg sorry for the delay getting to this PR. The Jenkins server these checks run on is a mac mini I have hosted at MacStadium. It's been offline for a while due to an OS upgrade that failed.

The CI just runs several of the scripts checked into the project, so as long as these are working for you and me, we can ignore Jenkins for now.

I will take a closer look at these changes and test them out myself tonight, but at a quick glance, I think this is a great idea. This tool has been using a private CommerceKit API to figure out which apps have pending updates but that API stopped returning anything some time back. I've dug around in a debugger several times looking for where this functionality moved to but haven't been successful.

Thanks for the PR! I will get back with any suggestions this week.

rgoldberg · 2021-02-18T02:07:58Z

Thanks, @phatblat. Glad you're recovering. No problem about delay. Take whatever time you need to stay healthy, and to ensure the PR is good.

I haven't looked throughout mas to see whether there are other commands that can be similarly fixed.

I tried to write tests, but got cryptic errors, so I decided to wait on tests until I communicated with you.

phatblat · 2021-02-18T02:28:03Z

Sorry about the changing format. I'd rather have that as a separate script but it was easy to add the --format flag to swiftlint and didn't think about the ramifications.

On the "InfoCommandSpec displays app details" test failures, I think a deterministic date format (option 2) would be ideal
since the output could be used by other CLI tools.

I'm curious, what locale setting do you have to get that format? That "yyyy-MM-dd" format (ISO-8601 minus the time) is perfect for the new format. You can find this formatter in AppInfoFormatter.

rgoldberg · 2021-02-18T03:17:31Z

No problem about formatting. I just didn't want to cause build or git history issues by changing things without asking. I thought that maybe I had missed some setup instructions that would have prevented the file reformatting.

I set all 4 date formats in System Preferences > Language & Region > Advanced… > Dates to "yyyy-MM-dd" a long time ago.

I'll have to read about the Apple DateFormatter to learn about how to set it programmatically, as I don't normally code in Swift or for Apple APIs.

Should I open a new issue & PR for the "InfoCommandSpec displays app details" date format change, or just include it in this PR in a separate commit?

phatblat · 2021-02-19T03:16:42Z

Yes, please create a separate PR for this date formatting change. That way it will be easier to track to see which version it changed in.

rgoldberg · 2021-02-19T07:13:36Z

I'll create a new issue & PR for the date format change after we finish with the current PR, as I don't want to have to manage multiple branches. The second PR will be simple, so easy to finish after this one.

phatblat · 2021-02-19T07:24:58Z

I managed to get the CI server back online tonight but builds are failing due to some issues I still need to clean up. So ignore the failing check for now.

rgoldberg · 2021-02-19T08:17:20Z

Will do. Please let me know whenever I need to do anything to improve / finish the PR.

phatblat · 2021-02-20T18:04:13Z

Wow, this works better than the App Store's "Updates" section! The App Store app doesn't show any of the 5 pending updates.

↪ mas outdated
1462114288 Grammarly for Safari (9.27 -> 9.26)
803453959 Slack (4.12.2 -> 4.13.0)
Warning: Identifier 927292435 not found in store. Was expected to identify iStat Mini.
411643860 DaisyDisk (4.12.1 -> 4.12)
1475897096 Jira (122.0.0 -> 123.1.0)
Warning: Identifier 781577745 not found in store. Was expected to identify Dumper.
Warning: Identifier 924726344 not found in store. Was expected to identify Deliveries.
1246284741 Install macOS High Sierra (13.6.02 -> 10.13.6)

Looked into the apps which weren't found:

iStat Mini - no longer in app store
Dumper - no longer in app store
Deliveries - has a different app store identifier now: 290986013

There might be a way to map apps like Deliveries that release updates as a new app to the one, but these are technically not an upgrade so the only thing we might be able to do is to have a more informative warning message.

The macOS installers have a weird versioning scheme which looks like it doesn't match the version reported by the iTunes Search API. This is a very minor issue as these are not usually kept around.

phatblat · 2021-02-20T18:11:09Z

Weird, both Grammarly and DaisyDisk are newer versions on my system than the app store reports.

1462114288 Grammarly for Safari (9.27 -> 9.26)
411643860 DaisyDisk (4.12.1 -> 4.12)

I installed them from the app store some time ago. Not sure how this can happen unless installing beta versions direct from the developer (which these aren't). I'll keep digging on the reason for this.

phatblat · 2021-02-20T21:13:35Z

Running the upgrade command attempted to upgrade all 8 of the items listed by the outdated command, even the ones that output a warning.

↪ mas upgrade
Upgrading 8 outdated applications:
Grammarly for Safari (9.27), Slack (4.12.2), iStat Mini (1.1), DaisyDisk (4.12.1), Jira (122.0.0), Dumper (1.2.1), Deliveries (3.2.4), Install macOS High Sierra (13.6.02)
==> Downloading Grammarly for Safari
==> Installed Grammarly for Safari
==> Downloading Slack
==> Installed Slack
==> Downloading iStat Mini
==> Installed iStat Mini
==> Downloading DaisyDisk
==> Installed DaisyDisk
==> Downloading Jira Cloud by Atlassian
==> Installed Jira Cloud by Atlassian
==> Downloading Dumper
==> Installed Dumper
==> Downloading Deliveries 3
==> Installed Deliveries 3
==> Downloading macOS High Sierra
==> Installed macOS High Sierra

Afterwards outdated lists 6 apps. Slack and Jira were the only two successfully upgraded.

↪ mas outdated
1462114288 Grammarly for Safari (9.27 -> 9.26)
Warning: Identifier 927292435 not found in store. Was expected to identify iStat Mini.
411643860 DaisyDisk (4.12.1 -> 4.12)
Warning: Identifier 781577745 not found in store. Was expected to identify Dumper.
Warning: Identifier 924726344 not found in store. Was expected to identify Deliveries.
1246284741 Install macOS High Sierra (13.6.02 -> 10.13.6)

Is there a way to exclude the items that generate a warning from the upgrade command?

MasKit/Commands/Upgrade.swift

rgoldberg · 2021-02-21T00:02:59Z

Weird, both Grammarly and DaisyDisk are newer versions on my system than the app store reports.

I installed them from the app store some time ago. Not sure how this can happen unless installing beta versions direct from the developer (which these aren't). I'll keep digging on the reason for this.

Maybe a version was released to the store, but was later retracted…

Resolves mas-cli#111 mas-cli#245 mas-cli#248 mas-cli#252 mas-cli#282 mas-cli#306 Possibly mas-cli#76 mas-cli#92 mas-cli#247 mas-cli#249 mas-cli#290

rgoldberg · 2021-03-01T04:47:13Z

The Jenkins/pr-merge timed out, but I'm not sure why…

phatblat

Thanks for all your great work on this! 💯

rgoldberg · 2021-03-15T00:23:32Z

@phatblat No problem. Glad to help. Thanks for maintaining / working on mas.

All but one issue that I referenced in the commit message are still open, so someone should go through the list and close the applicable issues. Some issues will definitely be fixed by this PR, some other issues might be fixed, but I'm not 100% sure as I didn't have the time to verify each.

phatblat · 2021-03-15T01:12:27Z

Thanks for reminding me. Once I get #327 completed I'll ask on each issue for confirmation.

rgoldberg · 2021-03-15T01:24:17Z

The issues listed after Resolves should all be fixed by this PR. Those listed after Possibly are ones I'm not 100% sure about.

houndci-bot reviewed Jan 17, 2021

View reviewed changes

MasKit/Commands/Outdated.swift Outdated Show resolved Hide resolved

MasKit/Commands/Outdated.swift Outdated Show resolved Hide resolved

houndci-bot reviewed Jan 17, 2021

View reviewed changes

MasKit/Commands/Upgrade.swift Outdated Show resolved Hide resolved

rgoldberg force-pushed the outdated branch 2 times, most recently from 4ff363c to b5a8553 Compare January 18, 2021 01:38

rgoldberg closed this Feb 13, 2021

rgoldberg force-pushed the outdated branch from b5a8553 to 9eaf57a Compare February 13, 2021 20:51

rgoldberg reopened this Feb 13, 2021

Fixed Warning typo in printError

f2a069d

rgoldberg force-pushed the outdated branch from bd7ca2d to 797f6c4 Compare February 13, 2021 21:40

phatblat self-assigned this Feb 18, 2021

phatblat added the 🐛 bug label Feb 18, 2021

phatblat added this to the Unreleased milestone Feb 18, 2021

phatblat requested changes Feb 20, 2021

View reviewed changes

MasKit/Commands/Upgrade.swift Outdated Show resolved Hide resolved

Fixed outdated & upgrade commands.

46ebd7c

Resolves mas-cli#111 mas-cli#245 mas-cli#248 mas-cli#252 mas-cli#282 mas-cli#306 Possibly mas-cli#76 mas-cli#92 mas-cli#247 mas-cli#249 mas-cli#290

rgoldberg force-pushed the outdated branch from 797f6c4 to 46ebd7c Compare February 28, 2021 13:41

Merge branch 'master' into outdated

754d4be

phatblat approved these changes Mar 14, 2021

View reviewed changes

phatblat merged commit 5539145 into mas-cli:master Mar 14, 2021

phatblat mentioned this pull request Mar 14, 2021

🔖 Release 1.8.1 #327

Merged

rgoldberg deleted the outdated branch March 15, 2021 00:19

duhd1993 mentioned this pull request Mar 17, 2021

🐛 [BUG] mas info sometimes does not show correct newest version #329

Closed

1 task

lukasbestle mentioned this pull request Mar 20, 2021

mas: The error was: ValueError: invalid literal for int() with base 10 ansible-collections/community.general#2060

Open

1 task

chris-araman mentioned this pull request Mar 21, 2021

🐛 [BUG] Messenger reports "upgrade" to lower version; always appears outdated #331

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix outdated & upgrade commands #312

Fix outdated & upgrade commands #312

rgoldberg commented Jan 17, 2021

rgoldberg commented Jan 18, 2021

rgoldberg commented Jan 19, 2021 •

edited

Loading

rgoldberg commented Jan 19, 2021 •

edited

Loading

rgoldberg commented Feb 13, 2021 •

edited

Loading

rgoldberg commented Feb 15, 2021 •

edited

Loading

phatblat commented Feb 18, 2021

rgoldberg commented Feb 18, 2021

phatblat commented Feb 18, 2021

rgoldberg commented Feb 18, 2021 •

edited

Loading

phatblat commented Feb 19, 2021 •

edited

Loading

rgoldberg commented Feb 19, 2021

phatblat commented Feb 19, 2021

rgoldberg commented Feb 19, 2021

phatblat commented Feb 20, 2021

phatblat commented Feb 20, 2021

phatblat commented Feb 20, 2021

rgoldberg commented Feb 21, 2021

rgoldberg commented Mar 1, 2021

phatblat left a comment

rgoldberg commented Mar 15, 2021

phatblat commented Mar 15, 2021

rgoldberg commented Mar 15, 2021

Fix outdated & upgrade commands #312

Fix outdated & upgrade commands #312

Conversation

rgoldberg commented Jan 17, 2021

rgoldberg commented Jan 18, 2021

rgoldberg commented Jan 19, 2021 • edited Loading

rgoldberg commented Jan 19, 2021 • edited Loading

rgoldberg commented Feb 13, 2021 • edited Loading

rgoldberg commented Feb 15, 2021 • edited Loading

phatblat commented Feb 18, 2021

rgoldberg commented Feb 18, 2021

phatblat commented Feb 18, 2021

rgoldberg commented Feb 18, 2021 • edited Loading

phatblat commented Feb 19, 2021 • edited Loading

rgoldberg commented Feb 19, 2021

phatblat commented Feb 19, 2021

rgoldberg commented Feb 19, 2021

phatblat commented Feb 20, 2021

phatblat commented Feb 20, 2021

phatblat commented Feb 20, 2021

rgoldberg commented Feb 21, 2021

rgoldberg commented Mar 1, 2021

phatblat left a comment

Choose a reason for hiding this comment

rgoldberg commented Mar 15, 2021

phatblat commented Mar 15, 2021

rgoldberg commented Mar 15, 2021

rgoldberg commented Jan 19, 2021 •

edited

Loading

rgoldberg commented Jan 19, 2021 •

edited

Loading

rgoldberg commented Feb 13, 2021 •

edited

Loading

rgoldberg commented Feb 15, 2021 •

edited

Loading

rgoldberg commented Feb 18, 2021 •

edited

Loading

phatblat commented Feb 19, 2021 •

edited

Loading