Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mip: subnet miner competition #3

Closed
wants to merge 11 commits into from
Closed

mip: subnet miner competition #3

wants to merge 11 commits into from

Conversation

grantdfoster
Copy link
Contributor

This PR creates an MIP based on masa-finance/masa-bittensor#295

@grantdfoster grantdfoster self-assigned this Oct 29, 2024
@grantdfoster grantdfoster linked an issue Oct 29, 2024 that may be closed by this pull request
[SPIKE]: Publish Miner Competition MIP masa-finance/masa-bittensor#295
Closed
@Luka-Loncar
Copy link

I'm adding some questions:

  1. Storage Impact of Tweet IDs
  • Can we estimate how many tweet IDs we expect to store per day/week/month? Like a ballpark estimate based on current throughput (but then again, if we remove limit, current estimate might be completely wrong)
  • Are we going to be required to increase storage capacities maybe?
  • Should we implement an expiration/pruning mechanism of some kind, or we keep them stored forever?
  • Is there any memory impact during runtime?
  • Will this affect validator node requirements? And if yes, how?
  1. API Rate Limits
  • What should our strategy be for handling Twitter API rate limits?
  • Should we add retry logic or fallback mechanisms?
  • What happens if a miner hits rate limits mid-competition?
  1. 20-Second Timeout
  • What's the current average response time across miners?
  • Have we tested the network impact of longer timeouts?
  • Should we have a fallback if 20 seconds prove insufficient?

P.S. I really like this MIP.

@5u6r054 5u6r054 self-requested a review November 4, 2024 23:32
5u6r054
5u6r054 approved these changes Nov 4, 2024
View reviewed changes
Copy link

@5u6r054 5u6r054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, a detailed, comprehensive starting point for a discussion.

teslashibe and others added 11 commits November 4, 2024 15:59
@teslashibe @grantdfoster
Initial commit
c287b69
@teslashibe @grantdfoster
docs: add MIP template, contribution guidelines, and code of conduct
42843d9 
Added the following documents to the repository:

- **MIP Template** (`MIP/mip_template.md`)
  - A structured template for Masa Improvement Proposals to ensure consistency and clarity.
- **Contribution Guidelines** (`CONTRIBUTING.md`)
  - Guidelines for contributing to the MIP repository, including submission processes and code style.
- **Code of Conduct** (`CODE_OF_CONDUCT.md`)
  - Established a code of conduct to foster a respectful and inclusive community.

_The Discussion Forum section is noted as coming soon and will be updated accordingly once available._
@teslashibe @grantdfoster
Update README.md
6fa6d53
@grantdfoster
chore: init
b5fa97b
@grantdfoster
feat: mip-2 first draft, editing now...
4379a3e
@grantdfoster
chore: edits and cleanup
ca5502d
@grantdfoster
chore: fixes
4b84dca
@grantdfoster
feat: adds modeling and revisions to mip2
99b804a
@grantdfoster
fix: spacing
7c3fcf5
@grantdfoster
fix: tweets by uid
7a05da6
@grantdfoster
fix: trends
af321f7
@grantdfoster grantdfoster force-pushed the mip--subnet-miner-competition branch from 5ee056b to af321f7 Compare November 4, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5u6r054 5u6r054 5u6r054 approved these changes

Assignees

@grantdfoster grantdfoster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SPIKE]: Publish Miner Competition MIP
4 participants
@grantdfoster @Luka-Loncar @5u6r054 @teslashibe