-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About 'MinimalAPIs'. The 'var app = builder.AddServices();' method name not very semanty.Bacause it doesn't look like building a 'WebApplication' object.It like add a service. #428
Comments
@zhenlei520 what do you think? |
My English not is very good,very chinese english.hope you can look understandand. |
MasaApp is only used to store global configurations. Normally, developers don't need to use it. Although it seems that it is not as elegant as IAbpApplication, because of this, it becomes easier to master it. |
AddServices is indeed easy to bring ambiguity, we will try to optimize it later |
I don't think we can work around the minimalapi map limitation right now. |
can try to register to the App through other methods, like |
So, what's next? |
I'm understand. Thanks! |
I will first determine whether the next plan is feasible and wait for the follow-up results |
I think just keep the design now. Until minimal api map remove limits. |
I have a suggestion. can refer to my 'NET.AutoApi' this package's design. it can dynamic will service method map to route.but this not is microsoft minialapi's design. this is blog address: https://www.cnblogs.com/norain/p/17049662.html @zhenlei520 |
the package need Add Mvc depend,it already not is minialapi. for reference only. |
ServiceBase is not the final form. 2.0 will be the final part of the design. |
The previous consideration was complicated. We can get WebApplication in a simpler way, which only changes the registration method, but does not need to modify the use of ServiceBase, like It doesn't require much code modification, unfortunately |
It's ok, just another way to use.it. |
The 'var app = builder.AddServices();' method does three thing inside. As follow:
1: Add 'MinimalAPIs' service
2: Building 'WebApplication' object and add to contianer collection
3: Initing 'MasaApp' class.
It deserves have a better name.
The text was updated successfully, but these errors were encountered: