Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MinimalAPIs): Support AddMasaMinimalAPIs #432

Merged
merged 1 commit into from
Feb 8, 2023
Merged

feat(MinimalAPIs): Support AddMasaMinimalAPIs #432

merged 1 commit into from
Feb 8, 2023

Conversation

zhenlei520
Copy link
Contributor

Description

Support AddMasaMinimalAPIs

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 requested a review from doddgu February 6, 2023 02:15
@zhenlei520 zhenlei520 force-pushed the feature/minimal-apis branch from 403d154 to 539524a Compare February 6, 2023 02:56
@zhenlei520 zhenlei520 marked this pull request as ready for review February 6, 2023 02:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

doddgu
doddgu approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit 465d832 into main Feb 8, 2023
@doddgu doddgu deleted the feature/minimal-apis branch February 8, 2023 11:45
@zhenlei520 zhenlei520 linked an issue Feb 27, 2023 that may be closed by this pull request
About 'MinimalAPIs'. The 'var app = builder.AddServices();' method name not very semanty.Bacause it doesn't look like building a 'WebApplication' object.It like add a service. #428
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu doddgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zhenlei520 @doddgu