feat(tsc-sdk): add tsc-sdk for alert #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlei520
reviewed
Jul 8, 2022
| public static async Task<TResult> GetByBodyAsync<TResult>(this ICallerProvider caller, string url, object body) where TResult : class | ||
| { | ||
| var request = new HttpRequestMessage(HttpMethod.Get, url); | ||
| if (body != null) |
There was a problem hiding this comment.
body is not null, if body is nullable, its type is object?
src/BasicAbility/Masa.Contrib.BasicAbility.Tsc/Extensions/CallerProviderExtensions.cs
Outdated
Show resolved
Hide resolved
src/BasicAbility/Masa.Contrib.BasicAbility.Tsc/Masa.Contrib.BasicAbility.Tsc.csproj
Outdated
Show resolved
Hide resolved
src/BasicAbility/Masa.Contrib.BasicAbility.Tsc/Service/LogService.cs
Outdated
Show resolved
Hide resolved
| public class CallerProviderExtensionsTests | ||
| { | ||
| [TestMethod] | ||
| public async Task GetByBodyAsyncTest() |
There was a problem hiding this comment.
The method name should reflect what you want to test, it can be longer
| public class LogServiceTests | ||
| { | ||
| [TestMethod] | ||
| public async Task GetFieldsAsyncTest() |
There was a problem hiding this comment.
The method name should reflect what you want to test, it can be longer
There was a problem hiding this comment.
deal with similar issues
test/Masa.Contrib.BasicAbility.Tsc.Test/Service/MetricServiceTests.cs
Outdated
Show resolved
Hide resolved
test/Masa.Contrib.BasicAbility.Tsc.Test/Service/MetricServiceTests.cs
Outdated
Show resolved
Hide resolved
zhenlei520
reviewed
Jul 18, 2022
src/BasicAbility/Masa.Contrib.BasicAbility.Tsc/Extensions/CallerProviderExtensions.cs
Show resolved
Hide resolved
src/BasicAbility/Masa.Contrib.BasicAbility.Tsc/Service/MetricService.cs
Outdated
Show resolved
Hide resolved
zhenlei520
approved these changes
Jul 19, 2022
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.