Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): Add Global Configuration #176

Merged
merged 7 commits into from
Aug 8, 2022
Merged

feat(data): Add Global Configuration #176

merged 7 commits into from
Aug 8, 2022

Conversation

zhenlei520
Copy link
Contributor

@zhenlei520 zhenlei520 commented Aug 5, 2022

Description

Add Global Configuration

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 requested a review from doddgu August 5, 2022 09:45

public class MasaAppConfigureOptionsRelation
{
public Dictionary<string, string> DataVariables { get; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pseudocode like:

public Dictionary<string, (string ConfigName/SectionName?, string DefaultValue)> Data { get; }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Processed

@zhenlei520 zhenlei520 requested a review from doddgu August 8, 2022 05:18
@zhenlei520 zhenlei520 requested a review from doddgu August 8, 2022 10:15
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit 8776eec into main Aug 8, 2022
@doddgu doddgu deleted the feature/data branch August 8, 2022 10:26
@zhenlei520 zhenlei520 added this to the 0.6.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants