Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Identity): Support custom User Model #192

Merged
merged 16 commits into from
Aug 15, 2022
Merged

refactor(Identity): Support custom User Model #192

merged 16 commits into from
Aug 15, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

Support custom User Model

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520
feat(Identity): Support custom Model
a05c43d
@zhenlei520
feat(Data): Support Serialization
add372c
@zhenlei520
Merge branch 'main' of https://github.com/masastack/MASA.Framework
f87a783 
� Conflicts:
�	Masa.Framework.sln
�	src/BuildingBlocks/Data/Masa.BuildingBlocks.Data/Masa.BuildingBlocks.Data.csproj
�	src/BuildingBlocks/Data/Masa.BuildingBlocks.Data/_Imports.cs
@zhenlei520
feat(Identity): Support custom user model
2a53f7f
@zhenlei520 zhenlei520 requested a review from doddgu August 10, 2022 08:54
@zhenlei520 zhenlei520 linked an issue Aug 10, 2022 that may be closed by this pull request
UserContext中Roles使用数组或字典，不使用IdentityRole #178
Closed
doddgu
doddgu requested changes Aug 12, 2022
View reviewed changes
src/Contrib/Authentication/Masa.Contrib.Authentication.Identity/DefaultUserContext.cs Outdated
@@ -33,7 +31,8 @@ internal class DefaultUserContext : UserContext
var modelRelation = ModelRelationCache.GetOrAdd(userType, (type) =>
{
var constructor = type.GetConstructors(BindingFlags.Instance | BindingFlags.Public)
.MinBy(x => x.GetParameters().Length)!;
.FirstOrDefault(c => c.GetParameters().Length == 0) ??
throw new InvalidOperationException($"【{type.Name}】 has a parameterless constructor");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

【 -> [

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Processed

@zhenlei520 zhenlei520 requested a review from doddgu August 12, 2022 09:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.5% 81.5% Coverage
0.0% 0.0% Duplication

doddgu
doddgu approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit acc6e77 into main Aug 15, 2022
@doddgu doddgu deleted the refactor/identity branch August 15, 2022 01:14
@zhenlei520 zhenlei520 mentioned this pull request Aug 16, 2022
Closed
11 tasks
@zhenlei520 zhenlei520 added this to the 0.6.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu doddgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

UserContext中Roles使用数组或字典，不使用IdentityRole
2 participants
@zhenlei520 @doddgu