Refactor(MinimalAPI): Refactor MinimalAPIs #238
Merged
+1,565
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doddgu
requested changes
Sep 14, 2022
| { | ||
| public string? Pattern { get; set; } | ||
|
|
||
| public string? Method { get; set; } |
| [AttributeUsage(AttributeTargets.Method)] | ||
| public class IncludeMappingAttribute : Attribute | ||
| { | ||
| public string? Pattern { get; set; } |
There was a problem hiding this comment.
Pattern? It's need a commet and sample. For example regex?
| @@ -1,15 +1,20 @@ | |||
| // Copyright (c) MASA Stack All rights reserved. | |||
| // Licensed under the MIT License. See LICENSE.txt in the project root for license information. | |||
|
|
|||
|
|
|||
| } | ||
|
|
||
| #endregion | ||
| internal void AutoMapRouter() |
There was a problem hiding this comment.
AutoMapRoute, and it will support map group for .net 7.
| { | ||
| var type = GetType(); | ||
|
|
||
| var methods = type |
| if (methodName.StartsWith("Add", StringComparison.OrdinalIgnoreCase) || | ||
| methodName.StartsWith("Upsert", StringComparison.OrdinalIgnoreCase)) return "POST"; | ||
|
|
||
| if (methodName.StartsWith("Update", StringComparison.OrdinalIgnoreCase)) return "PUT"; |
| public string? Version { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// service name, defaults to null |
There was a problem hiding this comment.
Why sometimes start with lowercase?
| public class Url | ||
| { | ||
| /// <summary> | ||
| /// The prefix, the default is null, consistent with the global prefix, if it is string.Empty, the Prefix is ignored |
There was a problem hiding this comment.
Formatter is $"{Prefix}/{Version}/{ServiceName}", any one IsNullOrWhiteSpace would be ignored.
5 tasks
|
SonarCloud Quality Gate failed. |
This was
linked to
issues
Sep 16, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor MinimalAPIs
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: