Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Refactor MinimalAPI #243

Merged
merged 15 commits into from
Sep 16, 2022
Merged

Refactor: Refactor MinimalAPI #243

merged 15 commits into from
Sep 16, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

Refactor MinimalAPI

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 requested a review from doddgu September 15, 2022 09:59
@zhenlei520 zhenlei520 force-pushed the refactor/service-base branch from aeeef7e to 7bd6a29 Compare September 15, 2022 10:50
doddgu
doddgu requested changes Sep 16, 2022
View reviewed changes
@zhenlei520 zhenlei520 force-pushed the refactor/service-base branch from eeaf009 to 24fde9f Compare September 16, 2022 09:12
@zhenlei520 zhenlei520 requested a review from doddgu September 16, 2022 09:16
doddgu
doddgu approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 requested a review from doddgu September 16, 2022 09:37
doddgu
doddgu approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit 80e6ece into main Sep 16, 2022
@doddgu doddgu deleted the refactor/service-base branch September 16, 2022 09:44
This was linked to issues Sep 16, 2022
Minimal APIs support auto map for RESTful #2
Closed
[Proposal] Minimal APIs ServiceBase Refactor #241
Closed
@zhenlei520 zhenlei520 mentioned this pull request Sep 16, 2022
Closed
11 tasks
@zhenlei520 zhenlei520 added this to the 0.6.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu doddgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

[Proposal] Minimal APIs ServiceBase Refactor Minimal APIs support auto map for RESTful
2 participants
@zhenlei520 @doddgu