Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MinimalAPI): Fix id does not support FromBodyAttribute, `FromFo… #253

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

zhenlei520
Copy link
Contributor

…rmAttribute, FromHeaderAttribute, FromQueryAttribute, FromServicesAttribute`

Description

Fix id does not support FromBodyAttribute, FromFormAttribute, FromHeaderAttribute, FromQueryAttribute, FromServicesAttribute

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 added the bug Something isn't working label Sep 20, 2022
@zhenlei520 zhenlei520 requested a review from doddgu September 20, 2022 08:47
…rmAttribute`, `FromHeaderAttribute`, `FromQueryAttribute`, `FromServicesAttribute`
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.5% 89.5% Coverage
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 merged commit b70ba63 into main Sep 20, 2022
@zhenlei520 zhenlei520 deleted the fix/minimal-api branch September 20, 2022 09:11
@zhenlei520 zhenlei520 mentioned this pull request Sep 20, 2022
11 tasks
@zhenlei520 zhenlei520 added this to the 0.6.0 milestone Sep 20, 2022
@zhenlei520 zhenlei520 linked an issue Dec 21, 2022 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Minimal APIs ServiceBase Refactor
2 participants