feat(UoW): add IUnitOfWorkAccessor and IUnitOfWorkManager support CreateDbContextAsync #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, IUnitOfWork Add IServiceProvider refactor(IntegrationEvents.Dapr): Refactoring background tasks
…ateDbContextAsync
doddgu
reviewed
Mar 30, 2022
|
|
||
| public UnitOfWorkManager(IServiceProvider serviceProvider) => _serviceProvider = serviceProvider; | ||
|
|
||
| public Task<IUnitOfWork> CreateDbContextAsync() |
There was a problem hiding this comment.
CreateDbContext has no IO opeartion, why need async?
There was a problem hiding this comment.
No need for async here, it will be removed in a later commit
| @@ -14,11 +16,9 @@ public DeleteLocalQueueExpiresProcessor(IOptions<DispatcherOptions> options) | |||
| /// </summary> | |||
| /// <param name="stoppingToken"></param> | |||
| /// <returns></returns> | |||
| public override Task ExecuteAsync(CancellationToken stoppingToken) | |||
| protected override Task ExecutingAsync(CancellationToken stoppingToken) | |||
There was a problem hiding this comment.
Why you need async? Support MQ in the future?
There was a problem hiding this comment.
No need for async here, it will be removed in a later commit
doddgu
reviewed
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs
Features
Refactor
Test