Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Caching): Supports nullable absolute expiration times #277

Merged
merged 4 commits into from
Sep 29, 2022
Merged

feat(Caching): Supports nullable absolute expiration times #277

merged 4 commits into from
Sep 29, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

Supports nullable absolute expiration times

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 added this to the 0.6.0 milestone Sep 28, 2022
@zhenlei520 zhenlei520 requested a review from doddgu September 28, 2022 10:42
@zhenlei520 zhenlei520 requested a review from doddgu September 29, 2022 01:18
doddgu
doddgu approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 merged commit bc89971 into main Sep 29, 2022
@zhenlei520 zhenlei520 deleted the feature/caching branch September 29, 2022 01:45
@zhenlei520 zhenlei520 mentioned this pull request Oct 26, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu doddgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenlei520 @doddgu