feat(Isolation): Added isolation support #28
Merged
+2,680
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doddgu
reviewed
Mar 31, 2022
src/Isolation/Masa.Contrib.Isolation.MultiTenancy/TenancySaveChangesFilter.cs
Outdated
Show resolved
Hide resolved
| if (_tenantContext != null) | ||
| stringBuilder.Append($"Tenant: [{_tenantContext.CurrentTenant?.Id ?? ""}]"); | ||
| var message = stringBuilder.ToString(); | ||
| return message.Substring(0, message.Length - 1); |
There was a problem hiding this comment.
"Tenant: [xxx]".Length - 1? And both null, Length - 1 = -1?
There was a problem hiding this comment.
stringBuilder cannot be null, at least one of _environmentContext and _tenantContext exists, which is restricted in UseIsolationUoW
There was a problem hiding this comment.
"Tenant: [xxx]".Length - 1?
There was a problem hiding this comment.
It was wrong before, now it is
private string GetMessage()
{
StringBuilder stringBuilder = new StringBuilder();
if (_environmentContext != null)
stringBuilder.Append($"Environment: [{_environmentContext.CurrentEnvironment}], ");
if (_tenantContext != null)
stringBuilder.Append($"Tenant: [{_tenantContext.CurrentTenant?.Id ?? ""}], ");
var message = stringBuilder.ToString();
return message.Substring(0, message.Length - 2);
}There was a problem hiding this comment.
src/Isolation/Masa.Contrib.Isolation.UoW.EF/Internal/TypeCommon.cs
Outdated
Show resolved
Hide resolved
src/Isolation/Masa.Contrib.Isolation.UoW.EF/Parser/MultiTenancy/HeaderTenantParserProvider.cs
Outdated
Show resolved
Hide resolved
…ent class name to IMultiEnvironment
zhenlei520
force-pushed
the
feature/isolation
branch
from
a4259ce to
7ff7d47
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore:
Docs
Feature:
Test