Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Caching) : Fix cache key formatting #285

Merged
merged 13 commits into from
Oct 19, 2022
Merged

fix(Caching) : Fix cache key formatting #285

merged 13 commits into from
Oct 19, 2022

Conversation

zhenlei520
Copy link
Contributor

@zhenlei520 zhenlei520 commented Oct 14, 2022 •
edited
Loading

Description

fix(Caching) : Fix cache key formatting

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 requested a review from doddgu October 14, 2022 08:28
@zhenlei520 zhenlei520 added this to the 0.6.0 milestone Oct 17, 2022
@zhenlei520 zhenlei520 requested a review from doddgu October 19, 2022 05:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.5% 93.5% Coverage
0.0% 0.0% Duplication

doddgu
doddgu approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit 63f4bb8 into main Oct 19, 2022
@doddgu doddgu deleted the fix/caching branch October 19, 2022 07:52
@zhenlei520 zhenlei520 changed the title feat(Caching) : Support cache key formatting fix(Caching) : Fix cache key formatting Oct 19, 2022
@zhenlei520 zhenlei520 mentioned this pull request Oct 26, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu doddgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenlei520 @doddgu