Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Caching): Remove ITypeAliasProvider injection #288

Merged
merged 2 commits into from
Oct 20, 2022
Merged

fix(Caching): Remove ITypeAliasProvider injection #288

merged 2 commits into from
Oct 20, 2022
+16 −7

Conversation

zhenlei520
Copy link
Contributor

Description

Remove ITypeAliasProvider injection

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Sorry, something went wrong.

@zhenlei520 zhenlei520 added the bug Something isn't working label Oct 20, 2022
@zhenlei520 zhenlei520 added this to the 0.6.0 milestone Oct 20, 2022
@zhenlei520 zhenlei520 requested a review from doddgu October 20, 2022 03:46
doddgu
doddgu approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 merged commit 49e8cf3 into main Oct 20, 2022
@zhenlei520 zhenlei520 deleted the fix/caching branch October 20, 2022 04:12
@zhenlei520 zhenlei520 changed the title fix: Remove ITypeAliasProvider injection fix(Caching): Remove ITypeAliasProvider injection Oct 20, 2022
@zhenlei520 zhenlei520 mentioned this pull request Oct 26, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhenlei520 @doddgu