Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RulesEngine): Add RulesEngine #311

Merged
merged 5 commits into from
Oct 26, 2022
Merged

feat(RulesEngine): Add RulesEngine #311

merged 5 commits into from
Oct 26, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

Add RulesEngine

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 added this to the 0.7.0 milestone Oct 26, 2022
@zhenlei520 zhenlei520 requested a review from doddgu October 26, 2022 05:20
@zhenlei520 zhenlei520 added the enhancement New feature or request label Oct 26, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.1% 92.1% Coverage
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 marked this pull request as ready for review October 26, 2022 09:17
doddgu
doddgu approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit be8e38d into main Oct 26, 2022
@doddgu doddgu deleted the feature/rule-engine branch October 26, 2022 09:21
@zhenlei520 zhenlei520 mentioned this pull request Oct 31, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu doddgu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenlei520 @doddgu