Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(caching): HashIncrementAsync, HashDecrementAsync support sliding expiration #314

Merged
merged 6 commits into from
Oct 31, 2022
Merged

feat(caching): HashIncrementAsync, HashDecrementAsync support sliding expiration #314

merged 6 commits into from
Oct 31, 2022

Conversation

zhenlei520
Copy link
Contributor

@zhenlei520 zhenlei520 commented Oct 28, 2022 •
edited
Loading

Description

  • Fix HashIncrementAsync, HashDecrementAsync do not support sliding expiration
  • Remove the restriction that the minimum value of HashDecrementAsync must be greater than 0
  • HashDecrementAsync failed to return null instead

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 added the bug Something isn't working label Oct 28, 2022
@zhenlei520 zhenlei520 added this to the 0.7.0 milestone Oct 28, 2022
@zhenlei520 zhenlei520 requested a review from doddgu October 28, 2022 09:28
@zhenlei520 zhenlei520 marked this pull request as ready for review October 28, 2022 09:59
@zhenlei520 zhenlei520 changed the title fix(caching): Fix HashIncrementAsync, HashDecrementAsync do not support sliding expiration feat(caching): HashIncrementAsync, HashDecrementAsync support sliding expiration Oct 31, 2022
@zhenlei520 zhenlei520 added enhancement New feature or request and removed bug Something isn't working labels Oct 31, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.9% 95.9% Coverage
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 requested a review from doddgu October 31, 2022 02:47
doddgu
doddgu approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit c2e4f69 into main Oct 31, 2022
@doddgu doddgu deleted the fix/caching branch October 31, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu doddgu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenlei520 @doddgu