Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(sdk-auth): sdk auth login #316

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Feature(sdk-auth): sdk auth login #316

merged 3 commits into from
Oct 31, 2022

Conversation

wuweilaiya
Copy link
Contributor

@wuweilaiya wuweilaiya commented Oct 31, 2022

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Copy link
Contributor

@zhenlei520 zhenlei520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @doddgu

@zhenlei520 zhenlei520 added this to the 0.7.0 milestone Oct 31, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wuweilaiya wuweilaiya merged commit 04874c1 into main Oct 31, 2022
@wuweilaiya wuweilaiya deleted the feat-sdk-auth-login branch October 31, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants