Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pref(Caching): Adjust the default value of some overloaded methods to optimize the user experience #318

Merged
merged 1 commit into from
Nov 1, 2022
Merged

pref(Caching): Adjust the default value of some overloaded methods to optimize the user experience #318

merged 1 commit into from
Nov 1, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

Adjust the default value of some overloaded methods to optimize the user experience

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 added the enhancement New feature or request label Nov 1, 2022
@zhenlei520 zhenlei520 added this to the 0.7.0 milestone Nov 1, 2022
@zhenlei520 zhenlei520 requested a review from doddgu November 1, 2022 03:29
@zhenlei520 zhenlei520 marked this pull request as ready for review November 1, 2022 03:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

doddgu
doddgu approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit 1429d3b into main Nov 1, 2022
@doddgu doddgu deleted the pref/Caching branch November 1, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu doddgu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenlei520 @doddgu