Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Caller): The default data source comes from environment variables, and then query the configuration #368

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

dapr appid acquisition order:

Environment Variables > Profiles > {Replace-Your-AppId}

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 added this to the 0.7.0 milestone Dec 8, 2022
@zhenlei520 zhenlei520 requested a review from MayueCif December 8, 2022 07:23
@zhenlei520 zhenlei520 marked this pull request as ready for review December 8, 2022 07:23
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@doddgu doddgu merged commit 8fe1659 into main Dec 8, 2022
@doddgu doddgu deleted the refactor/caller branch December 8, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants