Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: local message #374

Merged
merged 5 commits into from
Dec 20, 2022
Merged

refactor: local message #374

merged 5 commits into from
Dec 20, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

local message

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 requested a review from doddgu December 14, 2022 03:47
@zhenlei520 zhenlei520 marked this pull request as ready for review December 14, 2022 04:15
@zhenlei520 zhenlei520 requested a review from doddgu December 20, 2022 10:47
@zhenlei520 zhenlei520 added this to the 0.7.0 milestone Dec 20, 2022
@zhenlei520 zhenlei520 force-pushed the refactor/localMessage branch from 0b6ba28 to b82ee92 Compare December 20, 2022 10:57
@zhenlei520 zhenlei520 force-pushed the refactor/localMessage branch from 9d78f87 to 2a8ce96 Compare December 20, 2022 11:04
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhenlei520 zhenlei520 requested a review from doddgu December 20, 2022 11:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.8% 82.8% Coverage
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 merged commit 414f67d into main Dec 20, 2022
@zhenlei520 zhenlei520 deleted the refactor/localMessage branch December 20, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants