Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): Simplify fetching custom resources #387

Merged
merged 6 commits into from
Dec 29, 2022
Merged

feat(i18n): Simplify fetching custom resources #387

merged 6 commits into from
Dec 29, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

Simplify fetching custom resources

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation


namespace Masa.BuildingBlocks.Ddd.Domain.Tests;

public class CustomerResource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom?customer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Processed

@zhenlei520 zhenlei520 requested a review from doddgu December 29, 2022 08:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -3,7 +3,7 @@

namespace Masa.BuildingBlocks.Ddd.Domain.Tests;

public class CustomerResource
public class CustomResource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name has been changed, you may need to refresh it

@zhenlei520 zhenlei520 requested a review from doddgu December 29, 2022 10:19
@doddgu doddgu merged commit aefcb1f into main Dec 29, 2022
@doddgu doddgu deleted the feature/i18n branch December 29, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants