Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pref: Modify and set the global Assembly collection and Remove GetAllEventTypes method #398

Merged
merged 4 commits into from
Jan 9, 2023
Merged

pref: Modify and set the global Assembly collection and Remove GetAllEventTypes method #398

merged 4 commits into from
Jan 9, 2023

Conversation

zhenlei520
Copy link
Contributor

Description

Modify and set the global Assembly collection and Remove GetAllEventTypes method

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 marked this pull request as ready for review January 8, 2023 10:14
@zhenlei520 zhenlei520 requested a review from doddgu January 8, 2023 10:14
doddgu
doddgu approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 merged commit af133e1 into main Jan 9, 2023
@zhenlei520 zhenlei520 deleted the pref/masaApp branch January 9, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doddgu doddgu doddgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenlei520 @doddgu