Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: change IMiddleware to IEventMiddleware #430

Merged
merged 2 commits into from
Feb 6, 2023
Merged

update: change IMiddleware to IEventMiddleware #430

merged 2 commits into from
Feb 6, 2023

Conversation

MapleWithoutWords
Copy link
Member

Description

I change 'IMiddleware' to 'IEventMiddleware'. and changed all inhert from IMiddleware subclass's name and base class name.

@doddgu doddgu requested a review from zhenlei520 February 3, 2023 10:02
@doddgu
Copy link
Contributor

doddgu commented Feb 3, 2023

@zhenlei520 PTAL

zhenlei520
zhenlei520 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@zhenlei520 zhenlei520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu
Copy link
Contributor

doddgu commented Feb 5, 2023

@zhenlei520 CI failed

@zhenlei520 zhenlei520 merged commit 7ceecc3 into masastack:main Feb 6, 2023
@zhenlei520 zhenlei520 linked an issue Feb 7, 2023 that may be closed by this pull request
The 'Masa.BuildingBlocks.Dispatcher.Events.IMiddleware' class name and 'Microsoft.AspNetCore.Http.IMiddleware' name repetition #427
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenlei520 zhenlei520 zhenlei520 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MapleWithoutWords @doddgu @zhenlei520