Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync official file JsonConfigurationFileParser.cs, modify read json s… #498

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

zyz
Copy link
Contributor

@zyz zyz commented Mar 15, 2023

…upport Array

Description

Sync official file JsonConfigurationFileParser.cs, modify read json support Array

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]
masastack/MASA.DCC#391

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [√] Code compiles correctly
  • [√] Created/updated tests

@doddgu doddgu requested a review from zhenlei520 March 15, 2023 05:53
@zyz zyz requested a review from zhenlei520 March 15, 2023 07:48
Copy link
Contributor

@zhenlei520 zhenlei520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.7% 83.7% Coverage
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 merged commit 1fa6eb9 into main Mar 15, 2023
@zhenlei520 zhenlei520 deleted the fix/issues-391-dccconfigrationreadsupportarray branch March 15, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants