Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:MappingConfigurationApi method's parameter name problem. #589

Merged
merged 3 commits into from
Apr 27, 2023
Merged

fix:MappingConfigurationApi method's parameter name problem. #589

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e15e455
fix:MappingConfigurationApi method's parameter name problem.
MapleWithoutWords Apr 27, 2023
cde974e
private method
MapleWithoutWords Apr 27, 2023
8c3f2f3
fix:remark problem
MapleWithoutWords Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...trib/Configuration/Masa.Contrib.Configuration/Options/MasaConfigurationRelationOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ public MasaConfigurationRelationOptions MappingLocal<TModel>(string? section = n
/// Map Section relationship By ConfigurationApi
/// </summary>
/// <typeparam name="TModel"></typeparam>
/// <param name="parentSection">The name of the parent section, if it is empty, it will be mounted under SectionType, otherwise it will be mounted to the specified section under SectionType</param>
/// <param name="appId">Distributed Configuration Center's appId</param>
/// <param name="section">The default is null, which is consistent with the mapping class name, and string.Empty when no root node exists</param>
/// <param name="name"></param>
/// <returns></returns>
public MasaConfigurationRelationOptions MappingConfigurationApi<TModel>(string parentSection, string? section = null, string? name = null)
public MasaConfigurationRelationOptions MappingConfigurationApi<TModel>(string appId, string? section = null, string? name = null)
where TModel : class
=> Mapping<TModel>(SectionTypes.ConfigurationApi, parentSection, section, name);
=> Mapping<TModel>(SectionTypes.ConfigurationApi, appId, section, name);

/// <summary>
/// Map Section relationship
Expand All @@ -41,7 +41,7 @@ public MasaConfigurationRelationOptions MappingConfigurationApi<TModel>(string p
/// <param name="name"></param>
/// <returns></returns>
/// <exception cref="ArgumentOutOfRangeException"></exception>
public MasaConfigurationRelationOptions Mapping<TModel>(SectionTypes sectionType, string parentSection, string? section = null, string? name = null)
private MasaConfigurationRelationOptions Mapping<TModel>(SectionTypes sectionType, string parentSection, string? section = null, string? name = null)
where TModel : class
{
name ??= Options.DefaultName;
Expand Down