feat(IdGenerator): Add IdGenerator.SimpleGuid and IdGenerator.SequentialGuid and IdGenerator.Snowflake #76

zhenlei520 · 2022-06-06T01:49:21Z

No description provided.

…SA.Contrib into feature/IdGenerator

… feature/IdGenerator � Conflicts: � Masa.Contrib.sln � src/BuildingBlocks/MASA.BuildingBlocks

… feature/IdGenerator � Conflicts: � src/BuildingBlocks/MASA.BuildingBlocks

… feature/IdGenerator

doddgu · 2022-06-06T02:07:01Z

Masa.Contrib.sln

+EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Masa.BuildingBlocks.Data.MappingExtensions", "src\BuildingBlocks\MASA.BuildingBlocks\src\Data\Masa.BuildingBlocks.Data.MappingExtensions\Masa.BuildingBlocks.Data.MappingExtensions.csproj", "{30DC35DF-9D86-443C-B26C-9053E6FCA434}"
+EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Masa.Contrib.Data.IdGenerator.SimpleGuid", "src\Data\IdGenerator\Masa.Contrib.Data.IdGenerator.SimpleGuid\Masa.Contrib.Data.IdGenerator.SimpleGuid.csproj", "{24E5BF57-33B6-4D5B-A32F-2F64D1A5954F}"


simple -> normal

doddgu · 2022-06-06T02:11:35Z

src/Data/IdGenerator/Masa.Contrib.Data.IdGenerator.SequentialGuid/SequentialGuidGenerator.cs

+namespace Masa.Contrib.Data.IdGenerator.SequentialGuid;
+
+/// <summary>
+/// This code is taken from jhtodd/SequentialGuid https://github.com/jhtodd/SequentialGuid/blob/master/SequentialGuid/Classes/SequentialGuid.cs


If there is no license, the copyright is available by default

doddgu · 2022-06-06T02:13:12Z

src/Data/IdGenerator/Masa.Contrib.Data.IdGenerator.SimpleGuid/README.zh-CN.md

+
+## Masa.Contrib.Data.IdGenerator.SimpleGuid
+
+Masa.Contrib.Data.IdGenerator.SimpleGuid是一个简单的id构造器，提供Guid类型的唯一标识


id构造器 -> Guid构造器

doddgu · 2022-06-06T02:15:45Z

src/Data/IdGenerator/Masa.Contrib.Data.IdGenerator.Snowflake.Distributed.Redis/BaseRedis.cs

+
+public class BaseRedis
+{
+    protected readonly IDistributedCacheClient DistributedCacheClient;


Field? Property?

doddgu · 2022-06-06T02:16:53Z

...r/Masa.Contrib.Data.IdGenerator.Snowflake.Distributed.Redis/DistributedIdGeneratorOptions.cs

+public class DistributedIdGeneratorOptions : IdGeneratorOptions
+{
+    /// <summary>
+    /// When there is no available WorkerId, recover the inactive WorkerId for 2 minutes


doddgu · 2022-06-06T02:20:03Z

...or/Masa.Contrib.Data.IdGenerator.Snowflake.Distributed.Redis/Internal/SnowflakeExtensions.cs

+{
+    public static long GetTimestamp(this DateTimeOffset dateTimeOffset, uint timeType)
+    {
+        if (timeType == 1)


What's the mean of the timeType?

The timestamp in Snowflake ID is milliseconds by default. By changing the timestamp type to seconds, the number of bits occupied by the timestamp can be reduced. For some scenarios with low concurrency, the second-level timestamp can be used, and the performance will be higher.

I mean you can use enum.

ok processed

doddgu · 2022-06-06T02:21:59Z

...tor/Masa.Contrib.Data.IdGenerator.Snowflake.Distributed.Redis/ServiceCollectionExtensions.cs

+                        distributedIdGeneratorOption));
+            }
+
+            long defaultHeartbeatinterval = 30 * 1000;


defaultHeartbeatinterval -> defaultHeartbeatInterval

doddgu · 2022-06-06T02:22:28Z

...tor/Masa.Contrib.Data.IdGenerator.Snowflake.Distributed.Redis/ServiceCollectionExtensions.cs

+            if (distributedIdGeneratorOption.RecycleTime <= defaultHeartbeatinterval)
+            {
+                throw new ArgumentOutOfRangeException(
+                    $"{nameof(distributedIdGenerators.RecycleTime)} RecycleTime must be greater than {defaultHeartbeatinterval}");


{nameof(distributedIdGenerators.RecycleTime)} RecycleTime?

doddgu · 2022-06-06T02:24:52Z

src/Data/IdGenerator/Masa.Contrib.Data.IdGenerator.Snowflake/BaseIdGenerator.cs

+    private readonly IWorkerProvider _workerProvider;
+
+    /// <summary>
+    /// initial timestamp


initial timestamp? start timestamp?

test/Masa.Contrib.Data.IdGenerator.Snowflake.BenchmarkDotnet.Tests/DistributedBenchmarks.cs

doddgu · 2022-06-06T10:19:15Z

...rator/Masa.Contrib.Data.IdGenerator.Snowflake.Distributed.Redis/DistributedWorkerProvider.cs

@@ -32,7 +32,7 @@ public class DistributedWorkerProvider : BaseRedis, IWorkerProvider
        ArgumentNullException.ThrowIfNull(distributedIdGeneratorOptions);

        _timestampType = distributedIdGeneratorOptions.TimestampType;
-        _recycleTime = distributedIdGeneratorOptions.RecycleTime;
+        _idleTimeOut = distributedIdGeneratorOptions.IdleTimeOut;
        _maxWorkerId = distributedIdGeneratorOptions.MaxWorkerId;
        _workerIdMinInterval = distributedIdGeneratorOptions.GetWorkerIdMinInterval;
        _currentWorkerKey = "snowflake.current.workerid";


Possible null reference assignment. in 79 line.

test/Masa.Contrib.Data.IdGenerator.Snowflake.Tests/IdGeneratorTest.cs

doddgu

LGTM

zhenlei520 added 26 commits May 23, 2022 16:10

feat(IIdGenerator): Added support for snowflake id

d7e04df

feat(Snowflake): support snowflake id

374be7a

feat(IdGenerator): Snowflake id supports distributed

e8b71eb

refactor(IdGenerator): Optimize WorkerId

9e9ad25

chore: Delete the IdGenerator.Yitter class library

e35079f

Merge branch 'feature/IdGenerator' of https://github.com/masastack/MA…

50fdad4

…SA.Contrib into feature/IdGenerator

feat(IdGenerator): Modify Distributed IdGenerator

288c5bf

docs: Modify the IdGenerator document

003adc5

feat(IdGenerator): Timestamp supports seconds

a6ea17b

feat(IdGenerator): Add IdGenerator BenchmarkDotnet

2951a5c

chore: remove invalid constructor

6b2fdf3

chore: Adjust namespace order

36a2e37

chore: update branch

6b4b0b5

Merge branch 'main' of https://github.com/masastack/MASA.Contrib into…

71f9cae

… feature/IdGenerator � Conflicts: � Masa.Contrib.sln � src/BuildingBlocks/MASA.BuildingBlocks

Merge branch 'main' of https://github.com/masastack/MASA.Contrib into…

ac347b9

… feature/IdGenerator � Conflicts: � src/BuildingBlocks/MASA.BuildingBlocks

feat(Mapping.Mapster): Extend object to support mapping

a49a642

feat(IIdGenerator): Added IIdGenerator<long> service registration

31105ea

docs(IdGenerator): Modify Snowflake document

2a02e3a

Merge branch 'main' of https://github.com/masastack/MASA.Contrib into…

d6ca712

… feature/IdGenerator

chore: MapperConfiguartionExtensions rename to MapperExtensions

89d74dc

Refactors(IdGenerator): Refactor SnowflakeId

2e2f907

feat(IdGenerator): Add SimpleGuidGenerator and SequentialGuidGenerator

1c4326d

chore: Modify IdGenerator

23278a1

docs(IdGenerator): Modify IdGenerator Document

9cd6472

docs(IdGenerator): Modify IdGenerator Document

d90eb18

test(IdGenerator): Remove unit tests using redis

bfc06a7

zhenlei520 added the enhancement label Jun 6, 2022

zhenlei520 requested a review from doddgu June 6, 2022 01:49

test(Mapping): Modify Mapping UnitTest

d52797f

doddgu requested changes Jun 6, 2022

View reviewed changes

zhenlei520 added 3 commits June 6, 2022 13:47

chore(IdGenerator): Adjust parameter names, documentation, etc.

5da5e56

chore: remove source

ab4da40

docs(IdGenerator): Add Benchmark data

1021804

zhenlei520 requested a review from doddgu June 6, 2022 06:42

Update README.zh-CN.md

66167ec

doddgu requested changes Jun 6, 2022

View reviewed changes

zhenlei520 added 3 commits June 7, 2022 11:10

chore: Modify SequentialGuidGenerator and handle warnings

66a6e09

chore: Add TimestampType

e961fda

chore: Handling warnings

faf8741

doddgu requested changes Jun 7, 2022

View reviewed changes

test/Masa.Contrib.Data.IdGenerator.Snowflake.Tests/IdGeneratorTest.cs Show resolved Hide resolved

doddgu approved these changes Jun 7, 2022

View reviewed changes

doddgu merged commit cc1848b into main Jun 7, 2022

doddgu deleted the feature/IdGenerator branch June 7, 2022 03:34

zhenlei520 linked an issue Jun 9, 2022 that may be closed by this pull request

推荐集成这个雪花ID #1

Closed

zhenlei520 mentioned this pull request Jun 9, 2022

MASA.Contrib Roadmap for 0.5.0 #42

Closed

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(IdGenerator): Add IdGenerator.SimpleGuid and IdGenerator.SequentialGuid and IdGenerator.Snowflake #76

feat(IdGenerator): Add IdGenerator.SimpleGuid and IdGenerator.SequentialGuid and IdGenerator.Snowflake #76

zhenlei520 commented Jun 6, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 6, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 7, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 6, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 6, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 6, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 6, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 7, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 6, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 6, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 6, 2022

doddgu Jun 6, 2022

zhenlei520 Jun 7, 2022

doddgu left a comment


		## Masa.Contrib.Data.IdGenerator.SimpleGuid

		Masa.Contrib.Data.IdGenerator.SimpleGuid是一个简单的id构造器，提供Guid类型的唯一标识

feat(IdGenerator): Add IdGenerator.SimpleGuid and IdGenerator.SequentialGuid and IdGenerator.Snowflake #76

feat(IdGenerator): Add IdGenerator.SimpleGuid and IdGenerator.SequentialGuid and IdGenerator.Snowflake #76

Conversation

zhenlei520 commented Jun 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doddgu left a comment

Choose a reason for hiding this comment