Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request webViewLink when listing #123

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

felipeelia
Copy link
Contributor

I'm not quite sure how to reproduce it, but for a couple of files, we were seeing a fatal error being generated when using the package with Oneduo\NovaFileManager:

Oneduo\NovaFileManager\Entities\Entity::url(): Return value must be of type string, bool returned

It turns out the getUrl() method does return false when webViewLink is null. To work around that this PR:

  1. Adds webViewLink to the list of fields required for lists
  2. Make sure the getUrl() returns a string, as stated in its PHPdoc block.

@masbug masbug merged commit 0b6d493 into masbug:2.x Oct 4, 2024
1 of 2 checks passed
@masbug
Copy link
Owner

masbug commented Oct 4, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants