-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency rules_proto_grpc to v5 #408
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughThe primary change involves updating the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- WORKSPACE (1 hunks)
Additional comments not posted (1)
WORKSPACE (1)
212-214
: Verify the integrity of the updatedrules_proto_grpc
dependency.The
http_archive
configuration has been correctly updated to version5.0.0
. Ensure that thesha256
hash matches the downloaded archive to maintain the integrity of the dependency.Run the following script to verify the integrity of the updated dependency:
6de6c4b
to
e3b6ad0
Compare
This PR contains the following updates:
4.5.0
->5.0.1
Release Notes
rules-proto-grpc/rules_proto_grpc (rules_proto_grpc)
v5.0.1
Compare Source
Fixed gRPC-Gateway OpenAPI plugin on Linux ARM64 #360
v5.0.0
Compare Source
The 5.0.0 release introduces support for Bzlmod and drops support for WORKSPACE. This has required a large restructure of the repo, with the code being split into multiple modules. A 'core' module provides common types and compilation support, whilst per-language modules provide the integration with each language's specific third-party modules and tools. Moving to Bzlmod provides a huge improvement in the stability and maintainability of these rules, as third-party transitive dependency management has been handed off to Bazel and new versions of gRPC and Protobuf should hopefully be able to be supported more rapidly.
At present, a limited number of languages have been migrated from the 4.x.x releases, with support for the remaining languages being tracked here. For these unsupported languages - or for WORKSPACE repos - it is recommended you continue using the 4.x.x releases.
The way you use these rules is largely unchanged, but unfortunately the paths used for
load
of the rules will have changed due to the splitting into language-specific modules. For example, the following load:Will become:
Details on the new rule loads can, as always, be found on each language's page in the documentation. Examples for each language are also provided in the repo's examples directory.
Some key other changes include:
Bazel Central Registry
--enable_runfiles
flag to be set)Should you have any issues with the new release, please open a new issue or discussion.
v4.6.0
Compare Source
General
Rust
preserve_proto_field_names
option is no longer set on the Serde plugin by default, as it cannot then be disabled. If you need this option, set if manually with theoptions
attr. #297Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
This change is