Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency rules_proto_grpc to v5 #408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 22, 2024

This PR contains the following updates:

Package Type Update Change
rules_proto_grpc http_archive major 4.5.0 -> 5.0.1

Release Notes

rules-proto-grpc/rules_proto_grpc (rules_proto_grpc)

v5.0.1

Compare Source

Fixed gRPC-Gateway OpenAPI plugin on Linux ARM64 #​360

v5.0.0

Compare Source

The 5.0.0 release introduces support for Bzlmod and drops support for WORKSPACE. This has required a large restructure of the repo, with the code being split into multiple modules. A 'core' module provides common types and compilation support, whilst per-language modules provide the integration with each language's specific third-party modules and tools. Moving to Bzlmod provides a huge improvement in the stability and maintainability of these rules, as third-party transitive dependency management has been handed off to Bazel and new versions of gRPC and Protobuf should hopefully be able to be supported more rapidly.

At present, a limited number of languages have been migrated from the 4.x.x releases, with support for the remaining languages being tracked here. For these unsupported languages - or for WORKSPACE repos - it is recommended you continue using the 4.x.x releases.

The way you use these rules is largely unchanged, but unfortunately the paths used for load of the rules will have changed due to the splitting into language-specific modules. For example, the following load:

load("@​rules_proto_grpc//go:defs.bzl", "go_proto_library")

Will become:

load("@​rules_proto_grpc_go//:defs.bzl", "go_proto_library")

Details on the new rule loads can, as always, be found on each language's page in the documentation. Examples for each language are also provided in the repo's examples directory.

Some key other changes include:

  • The versions of gRPC and Protobuf are updated to the latest available in
    Bazel Central Registry
  • Python now pulls gRPC and Protobuf from pip wheels
  • Buf rules now work on Windows (requires the --enable_runfiles flag to be set)

Should you have any issues with the new release, please open a new issue or discussion.

v4.6.0

Compare Source

General
  • Fixed incompatibility with Bazel 7 for the C, C++ and Objective-C rules. #​298
Rust
  • Breaking change: The preserve_proto_field_names option is no longer set on the Serde plugin by default, as it cannot then be disabled. If you need this option, set if manually with the options attr. #​297
  • Disabled Clippy lints in generated code. #​296

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.


This change is Reviewable

Copy link

coderabbitai bot commented Aug 22, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The primary change involves updating the http_archive configuration for the rules_proto_grpc dependency in the WORKSPACE file. The version has been modified from 4.5.0 to 5.0.0, along with corresponding updates to the strip_prefix, urls, and sha256 hash fields. This change reflects a straightforward upgrade of the dependency to the latest version.

Changes

Files Change Summary
WORKSPACE Updated http_archive for rules_proto_grpc from version 4.5.0 to 5.0.0. Updated strip_prefix, urls, and sha256 accordingly.

Poem

In the garden of code, a change took flight,
Upgraded the rules, making futures bright.
From four-point-five to five, we leap,
New features and fixes, promises to keep.
Hops of joy through the digital glade,
A brighter tomorrow, with progress made! 🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6ac895c and 6de6c4b.

Files selected for processing (1)
  • WORKSPACE (1 hunks)
Additional comments not posted (1)
WORKSPACE (1)

212-214: Verify the integrity of the updated rules_proto_grpc dependency.

The http_archive configuration has been correctly updated to version 5.0.0. Ensure that the sha256 hash matches the downloaded archive to maintain the integrity of the dependency.

Run the following script to verify the integrity of the updated dependency:

@renovate renovate bot force-pushed the renovate/rules_proto_grpc-5.x branch from 6de6c4b to e3b6ad0 Compare September 30, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants