Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up Next.js environment with tanstack-query #4

Merged
merged 7 commits into from
May 16, 2024

Conversation

poiu694
Copy link
Member

@poiu694 poiu694 commented May 15, 2024

Issue Number

#2

Description

구현 내용 및 작업한 내용

  • create-next-app 을 이용해서 next+ts+tailwind+eslint 를 설정했습니다.
  • stream ssr without prefetching 을 위해 실험 기능을 써봤습니다! 이건 카톡에서 공유된 내용이에요 :)
  • /query-test 를 통해 Suspense + query 작동에 대해 확인해봤습니다.

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

@poiu694 poiu694 self-assigned this May 15, 2024
@poiu694 poiu694 requested review from hee-suh and Pridesd as code owners May 15, 2024 07:49
Copy link
Member

@hee-suh hee-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커밋 로그 넘 좋아요 🥹
코멘트 해결되면 Approve로 변경할게요!

src/app/(test)/query-test/Components.tsx Show resolved Hide resolved
src/app/provider.tsx Show resolved Hide resolved
src/app/api/error.ts Show resolved Hide resolved
Copy link
Member

@hee-suh hee-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
고생하셨습니다~!!

@poiu694 poiu694 merged commit 4b7b9a0 into main May 16, 2024
@poiu694 poiu694 deleted the feature/next-scaffold branch May 16, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants