Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mdc #452

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Feature/mdc #452

merged 2 commits into from
Jul 27, 2024

Conversation

hocaron
Copy link
Collaborator

@hocaron hocaron commented Jul 27, 2024

PR 타입

개요

  • 회원번호로 로깅을 할 수 있도록 mdc 를 추가합니다. 아래와 같이 로깅 가능
2024-07-27 15:09:13.981 [http-nio-8080-exec-3] INFO  [MemberControllerAdvice.java:57] [memberId: 83] - handleBadRequestException: null
kr.mashup.branding.domain.exception.BadRequestException: null
	at kr.mashup.branding.util.CipherUtil.decryptAES128(CipherUtil.java:31)
image

변경사항

@hocaron hocaron changed the base branch from develop to master July 27, 2024 06:14
alertjjm
alertjjm approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@alertjjm alertjjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image
memberid랑 여기에 몇초 몇초로 달랐는지도 표시되면 더 좋을것같습니당~

eunjungL
eunjungL approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@eunjungL eunjungL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넘 좋아요 👍 👍

@hocaron
Copy link
Collaborator Author

hocaron commented Jul 27, 2024 •
edited
Loading

memberid랑 여기에 몇초 몇초로 달랐는지도 표시되면 더 좋을것같습니당~

굿이용👍 디버깅할 때 도움 되겠네용! 93f3046 에서 반영완료요~!

@hocaron hocaron merged commit bd0647a into master Jul 27, 2024
1 check passed
@hocaron hocaron deleted the feature/mdc branch September 19, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunjungL eunjungL eunjungL approved these changes

@alertjjm alertjjm alertjjm approved these changes

@kh0712 kh0712 Awaiting requested review from kh0712

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hocaron @alertjjm @eunjungL