Skip to content

Popover is not controllable #180

@stomita

Description

@stomita
Collaborator

Currently the hidden property is used for representing default value, and the visibility is totally uncontrollable from outside. To be controllable from outside, change hidden property as controlled one and introduce defaultHidden property to tell the default visibility.

There are public component methods like hidden() or mouseEntered() which are not documented, and essentially not used (in any part of the rest of the code).

IMO making method public in React component is not in good manner to access the internal state - it should be totally be stateless by default.

Activity

costagolub

costagolub commented on Sep 6, 2017

@costagolub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @stomita@costagolub

        Issue actions

          Popover is not controllable · Issue #180 · mashmatrix/react-lightning-design-system