Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Semver codable #37

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Make Semver codable #37

merged 6 commits into from
Oct 9, 2024

Conversation

josemanuelmartin
Copy link

PR's key points

Make SemVer codable for use in firebase @RemoteConfigProperty.

How to review this PR?

sebastianvarela
sebastianvarela previously approved these changes Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (0b08e17) to head (023f42a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   92.88%   92.84%   -0.04%     
==========================================
  Files         144      146       +2     
  Lines        6115     6125      +10     
==========================================
+ Hits         5680     5687       +7     
- Misses        435      438       +3     
Flag Coverage Δ
ios 92.84% <100.00%> (?)
mac 92.84% <100.00%> (-0.04%) ⬇️
tv 92.84% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThorBot
Copy link

ThorBot commented Oct 8, 2024

7 Warnings
⚠️ Source/Foundation/Extensions/TimeZoneExtensions.swift#L439: Extension declares a conformance of imported type 'TimeZone' to imported protocol 'CaseIterable'; this will not behave correctly if the owners of 'Foundation' introduce this conformance in the future
⚠️ Source/Foundation/Extensions/URLExtensions.swift#L94: Extension declares a conformance of imported type 'URL' to imported protocol 'Comparable'; this will not behave correctly if the owners of 'Foundation' introduce this conformance in the future
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L15: 'CC_MD5' was deprecated in iOS 13.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L100: 'withUnsafeBytes' is deprecated: use withUnsafeBytes\<R\>(_: (UnsafeRawBufferPointer) throws -\> R) rethrows -\> R instead
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L104: 'withUnsafeBytes' is deprecated: use withUnsafeBytes\<R\>(_: (UnsafeRawBufferPointer) throws -\> R) rethrows -\> R instead
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L15: 'CC_MD5' was deprecated in macOS 10.15: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L15: 'CC_MD5' was deprecated in tvOS 13.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
6 Messages
📖 MasMagicPills-iOSTests: Executed 257 tests, with 0 failures (0 expected) in 9.063 (9.063) seconds
📖 MasMagicPills-macOSTests: Executed 202 tests, with 0 failures (0 expected) in 5.785 (5.785) seconds
📖 MasMagicPills-tvOSTests: Executed 257 tests, with 0 failures (0 expected) in 8.566 (8.566) seconds
📖 ⌛️ [iOS] Slowest test: test_false took 5.008 seconds
📖 ⌛️ [mac] Slowest test: test_false took 5.014 seconds
📖 ⌛️ [tv] Slowest test: test_false took 5.014 seconds

SwiftLint found issues

Warnings

File Line Reason
UIViewExtensions.swift 186 Returning Void in a function declaration is redundant (redundant_void_return)
ZoomAndSnapFlowLayout.swift 80 Prefer implicit returns in closures, functions and getters (implicit_return)
CurrencyCodeType.swift 27 Include a single empty line between switch cases (vertical_whitespace_between_cases)
CurrencyCodeType.swift 29 Include a single empty line between switch cases (vertical_whitespace_between_cases)
StringExtensions+Values.swift 8 Include a single empty line between switch cases (vertical_whitespace_between_cases)
SemVerTests.swift 64 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 67 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 70 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 74 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 77 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 80 Lines should not have trailing whitespace (trailing_whitespace)
FakeBundle.swift 20 Include a single empty line between switch cases (vertical_whitespace_between_cases)

Generated by 🚫 Danger

@sebastianvarela sebastianvarela merged commit 9176798 into master Oct 9, 2024
3 of 4 checks passed
@sebastianvarela sebastianvarela deleted the make-semver-codable branch October 9, 2024 15:21
@sebastianvarela sebastianvarela restored the make-semver-codable branch October 9, 2024 15:54
sebastianvarela pushed a commit that referenced this pull request Oct 9, 2024
* Make Semver codable

* Added Scanfile

* Fix Scanfile

* Fixed fastlane

* Removed tests

---------

Co-authored-by: JoseManuel <JoseManuel@MacBook-Pro.local>
@sebastianvarela sebastianvarela deleted the make-semver-codable branch October 9, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants