-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump up java-test to 0.40.1 #3348
Conversation
@williamboman I'd like to help testing this as this update is quite important for Java Devs. Can you (or @s1n7ax ) give me a quick pointer how configure mason to point to the source branch of this PR? I found this, but unsure how to set the branch: This information could probably also be added to CONTRIBUTING.md |
@mikehaertl 0.40.1 clean build stopped working for me. I don't know if it worked the first time because I had a cache. Main branch however is working. So, I forked the vscode-java-test and created a new tag 0.40.2 from main. I created a new mason registry called nvim-java-mason-registry. It uses my java-test fork and edit: edit: I didn't know #3083 PR existed when this is created. You could check the comments in there if you want to get that exact PR working. return {
'williamboman/mason.nvim',
opts = {
registries = {
'github:nvim-java/nvim-java-mason-registry',
'github:mason-org/mason-registry',
},
},
} |
@s1n7ax Thanks for the update and for the pointer to that other issue. I quickly tried your registry but had some trouble due to changed paths or something and had no time to fix my config. TBH I will then probably wait a bit and see if there's an "official" solution. Thanks for your effort nonetheless. |
Hello. I have created a workflow that release build artifacts on new release of java-test. This is daily checking to see if there are new relea are available in the original project that's not available in the current releases. NOTE that https://github.com/nvim-java/vscode-java-test-releases I have a custom mason registry to use the releases from this here https://github.com/nvim-java/mason-registry Adding the registry to mason & {
'williamboman/mason.nvim',
opts = {
registries = {
'github:nvim-java/mason-registry',
'github:mason-org/mason-registry',
},
},
} |
Nice @s1n7ax! I like the idea of the community taking ownership of specific areas 👍 (I know creating your own Mason registry is a hassle currently, I need to make it much easier and document it). As for |
@williamboman That's better. Idea of adding third party registries are brilliant however, in reality, pretty much most issues we got had something to do with updating mason registries. So far it's always user messing up something when setting up mason. I would like some improvements when it comes to mason APIs available for plugin developers at least to show better error messages to user. I will create an issue with challenges but in simple words, registry versioning & dynamic registry loading would be perfect. |
After the removal of .vsix from releases, updating
java-test
is not possible. So, this change will build the package from source. #3036IMPORTANT: path to shared
jar
s in thevsix
wasjava-test/extension/server/*.jar
but when build with source, there is noextension
directory anymore. This might break existing configs.Current latest version in Mason-registry also has a bug where there is an error upon test search. microsoft/vscode-java-test#1625 so updating current version is important.