Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 standards #109

Merged
merged 6 commits into from
Jul 12, 2023
Merged

v1 standards #109

merged 6 commits into from
Jul 12, 2023

Conversation

Ben-Rey
Copy link
Contributor

@Ben-Rey Ben-Rey commented Jul 6, 2023

No description provided.

@Ben-Rey Ben-Rey linked an issue Jul 6, 2023 that may be closed by this pull request
@Ben-Rey Ben-Rey requested review from gregLibert and qdrn and removed request for gregLibert July 7, 2023 12:40
@Ben-Rey
Copy link
Contributor Author

Ben-Rey commented Jul 7, 2023

Maybe a little light at the moment. Do you think we need to explain certain parts of the code for beginners?
Other blockchains have also added a section on risks and regulation.

@qdrn
Copy link
Contributor

qdrn commented Jul 7, 2023

Other blockchains have also added a section on risks and regulation.

What do you mean ? Can you share a link ?

Do you think we need to explain certain parts of the code for beginners?

I would create tutorials on how to create a FT and NFT and cross-reference from here.

docs/build/smart-contract/standards.md Outdated Show resolved Hide resolved
docs/build/smart-contract/standards.md Outdated Show resolved Hide resolved
@Ben-Rey
Copy link
Contributor Author

Ben-Rey commented Jul 7, 2023

Other blockchains have also added a section on risks and regulation.

What do you mean ? Can you share a link ?

https://opentezos.com/defi/token-standards#risks

Do you think we need to explain certain parts of the code for beginners?

I would create tutorials on how to create a FT and NFT and cross-reference from here.

👍

@qdrn
Copy link
Contributor

qdrn commented Jul 7, 2023

Other blockchains have also added a section on risks and regulation.

What do you mean ? Can you share a link ?

https://opentezos.com/defi/token-standards#risks

Do you think we need to explain certain parts of the code for beginners?

I would create tutorials on how to create a FT and NFT and cross-reference from here.

👍

It could be useful in general but it's too early given the state of the documentation. Maybe adding a small paragraph that explains why it's important to follow a standard is useful tho? Similar to tezos but much lighter I'd say.

@Ben-Rey
Copy link
Contributor Author

Ben-Rey commented Jul 10, 2023

Other blockchains have also added a section on risks and regulation.

What do you mean ? Can you share a link ?

Do you think we need to explain certain parts of the code for beginners?

I would create tutorials on how to create a FT and NFT and cross-reference from here.

If you agree, we'll create these tutorials in a future issue, as the standards are being rewritten with protobuf.

@Ben-Rey Ben-Rey marked this pull request as ready for review July 10, 2023 06:20
@Ben-Rey Ben-Rey requested a review from qdrn July 10, 2023 07:26
@qdrn
Copy link
Contributor

qdrn commented Jul 10, 2023

If you agree, we'll create these tutorials in a future issue, as the standards are being rewritten with protobuf.

Yes, of course!

Copy link
Contributor

@qdrn qdrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put standards under its own section under developer tools. WDYT ?

LGTM otherwise!

@Ben-Rey Ben-Rey force-pushed the 107-standards-page branch from 4baa4c7 to 044538c Compare July 11, 2023 04:06
@Ben-Rey
Copy link
Contributor Author

Ben-Rey commented Jul 11, 2023

developer

Cool, I moved it in the tool section

@Ben-Rey Ben-Rey requested a review from qdrn July 11, 2023 06:05
@qdrn qdrn merged commit 3cde907 into main Jul 12, 2023
@qdrn qdrn deleted the 107-standards-page branch July 12, 2023 12:28
@qdrn qdrn mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standards page
2 participants