Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

339 constant key manager #340

Merged
merged 4 commits into from
May 24, 2024
Merged

339 constant key manager #340

merged 4 commits into from
May 24, 2024

Conversation

gregLibert
Copy link
Contributor

No description provided.

@gregLibert gregLibert requested review from leoloco and Ben-Rey May 23, 2024 13:12
@gregLibert gregLibert linked an issue May 23, 2024 that may be closed by this pull request
Constant Key Manager #339
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

leoloco
leoloco approved these changes May 23, 2024
View reviewed changes
Copy link

@leoloco leoloco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we implement some sort of domain separator for multiple files smart contracts ?
To prevent reentrancy/duplicate keys issues.
Or maybe it should be done at sc level

@gregLibert gregLibert merged commit 3f1d3b9 into main May 24, 2024
4 checks passed
@gregLibert gregLibert deleted the 339-constant-key-manager branch May 24, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASAPSegfault ASAPSegfault ASAPSegfault approved these changes

@Ben-Rey Ben-Rey Ben-Rey approved these changes

@leoloco leoloco leoloco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constant Key Manager
4 participants
@gregLibert @leoloco @Ben-Rey @ASAPSegfault