Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust build #1

Merged
merged 5 commits into from
Jun 2, 2023
Merged

Add rust build #1

merged 5 commits into from
Jun 2, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented May 31, 2023

  • Build ABIs
  • Build APIs
  • CI

@aoudiamoncef aoudiamoncef force-pushed the feature/add-rust-bindings branch from c150f33 to d6a9ec7 Compare May 31, 2023 17:31
@aoudiamoncef aoudiamoncef requested review from bilboquet and modship May 31, 2023 18:04
@aoudiamoncef aoudiamoncef marked this pull request as ready for review May 31, 2023 18:04
@modship
Copy link
Member

modship commented Jun 1, 2023

Hi @aoudiamoncef , i have added massa-xtask module in testnet_23. You can add your task into it and run it with your build.rs.
massalabs/massa#4005

Sorry, i see only now that is not massa repository

build.bat Show resolved Hide resolved
rust/Cargo.toml Outdated Show resolved Hide resolved
rust/build.rs Outdated Show resolved Hide resolved
@bilboquet
Copy link

Hi @aoudiamoncef , i have added massa-xtask module in testnet_23. You can add your task into it and run it with your build.rs. massalabs/massa#4005

Sorry, i see only now that is not massa repository

we can't use "your" xtask here
but xtask would allow to remove build.bat and build.sh so it's a good idea (and xtask is cheap)

@aoudiamoncef
Copy link
Contributor Author

Hi @aoudiamoncef , i have added massa-xtask module in testnet_23. You can add your task into it and run it with your build.rs. massalabs/massa#4005
Sorry, i see only now that is not massa repository

we can't use "your" xtask here but xtask would allow to remove build.bat and build.sh so it's a good idea (and xtask is cheap)

This script will be used to rebuild all projects. Rust, AS, Go .. etc

@aoudiamoncef aoudiamoncef requested a review from bilboquet June 1, 2023 12:04
Copy link

@bilboquet bilboquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view it can be merged

Two options here:

  • Merge then rename the project if we choose so
  • Wait for a consensus about the name then merge

I feel like Damir is trusting us on this point (cf #core «Do what you feel is right on that naming 🙂»)
So I'd go remane to massa-proto-rs (an manage only rust here)
then explore use of xtask while the name is discussed (maybe)

Up to you (to merge or wait) :)

@aoudiamoncef aoudiamoncef requested a review from bilboquet June 2, 2023 14:58
@aoudiamoncef
Copy link
Contributor Author

Hi @modship @bilboquet, I'm ready to merge this first version

@aoudiamoncef aoudiamoncef merged commit 18fa519 into main Jun 2, 2023
@aoudiamoncef aoudiamoncef deleted the feature/add-rust-bindings branch June 2, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants