-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust build #1
Conversation
aoudiamoncef
commented
May 31, 2023
•
edited
Loading
edited
- Build ABIs
- Build APIs
- CI
c150f33
to
d6a9ec7
Compare
Hi @aoudiamoncef , i have added massa-xtask module in testnet_23. You can add your task into it and run it with your build.rs. Sorry, i see only now that is not massa repository |
we can't use "your" xtask here |
This script will be used to rebuild all projects. Rust, AS, Go .. etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my point of view it can be merged
Two options here:
- Merge then rename the project if we choose so
- Wait for a consensus about the name then merge
I feel like Damir is trusting us on this point (cf #core «Do what you feel is right on that naming 🙂»)
So I'd go remane to massa-proto-rs (an manage only rust here)
then explore use of xtask while the name is discussed (maybe)
Up to you (to merge or wait) :)
Hi @modship @bilboquet, I'm ready to merge this first version |