Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setTokenURI function #139

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Remove setTokenURI function #139

merged 2 commits into from
Jan 3, 2024

Conversation

Ben-Rey
Copy link
Contributor

@Ben-Rey Ben-Rey commented Jan 3, 2024 •
edited
Loading

Its presence was recently highlighted in a CertiK bounty

@Ben-Rey Ben-Rey linked an issue Jan 3, 2024 that may be closed by this pull request
Ability for NFT Owners to Alter Token URIs #137
Closed
@Ben-Rey Ben-Rey requested a review from Thykof January 3, 2024 11:11
@Ben-Rey Ben-Rey marked this pull request as ready for review January 3, 2024 11:11
@Ben-Rey Ben-Rey self-assigned this Jan 3, 2024
Thykof
Thykof requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'assertIsOwner' is defined but never used

@Ben-Rey Ben-Rey requested a review from Thykof January 3, 2024 14:05
@Ben-Rey Ben-Rey merged commit 8743ed2 into main Jan 3, 2024
3 checks passed
@Ben-Rey Ben-Rey deleted the 137-ability-for-nft-owners-to-alter-token-uris branch January 3, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thykof Thykof Thykof approved these changes

Assignees

@Ben-Rey Ben-Rey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability for NFT Owners to Alter Token URIs
2 participants
@Ben-Rey @Thykof