Add activation delay when transitioning from LockedIn to Active (#3723)

* Add activation delay when transitioning from LockedIn to Active

* Update doc with state machine auto gen graph

* Fix ComponentState serialization at locked in state

* Improve mip store raw deserializer context msg

* Fix test_factory_strategy_at unit test

* Clippy fixes

* Use >= instead of > for state update

* Use >= instead of > for state update (round 2)

---------

Co-authored-by: sydhds <sd@massa.net>

massa-versioning-worker/src/lib.rs

@@ -20,6 +20,10 @@
 //! * A state machine (stores the current state of deployment for a MipInfo)
 //! * A history (stores a list of `Advance` message that 'really' updated the state machine)
 //!
+//! A auto generated graph of the state machine can be found here:
+//! * dot -Tpng ./target/machine/componentstate.dot > ./target/machine/componentstate.png
+//! * xdg-open ./target/machine/componentstate.png
+//!
 //! History is there in order to:
 //! * Query the state at any time, so you can query MipStore and ask the best version at any time
 //! * Used a lot when merging 2 MipStore:

massa-versioning-worker/src/test_helpers/versioning_helpers.rs

@@ -3,6 +3,7 @@ use crate::versioning::{Advance, ComponentState, MipInfo, MipState};
 use massa_models::config::VERSIONING_THRESHOLD_TRANSITION_ACCEPTED;
 use massa_time::MassaTime;
 
+// TODO: rename versioning_info
 pub fn advance_state_until(at_state: ComponentState, versioning_info: &MipInfo) -> MipState {
     // A helper function to advance a state
     // Assume enough time between versioning info start & timeout
@@ -26,6 +27,7 @@ pub fn advance_state_until(at_state: ComponentState, versioning_info: &MipInfo)
         timeout,
         threshold: Default::default(),
         now: start.saturating_add(MassaTime::from(1)),
+        activation_delay: versioning_info.activation_delay,
     };
     state.on_advance(&advance_msg);
 
@@ -47,7 +49,11 @@ pub fn advance_state_until(at_state: ComponentState, versioning_info: &MipInfo)
         return state;
     }
 
-    advance_msg.now = timeout.saturating_add(MassaTime::from(1));
+    advance_msg.now = advance_msg
+        .now
+        .saturating_add(versioning_info.activation_delay)
+        .saturating_add(MassaTime::from(1));
+
     state.on_advance(&advance_msg);
     // Active
     state